From 15d6e45c93d3c2fab2430a88ca17cee910ad59a4 Mon Sep 17 00:00:00 2001
From: Joshua Hiller <joshua.hiller@crowdstrike.com>
Date: Mon, 20 Nov 2023 02:23:15 -0500
Subject: [PATCH] Add app_id to CreateSavedSearchesIngestV1

---
 CHANGELOG.md                     |  6 +++++-
 src/falconpy/foundry_logscale.py | 14 +++++++++-----
 tests/test_foundry_logscale.py   |  2 +-
 3 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index d006fd396..964ea1f48 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,9 +10,13 @@
     ```
     - `_auth_object/_uber_interface.py`
     - `_service_class/_service_class.py`
++ Added: `app_id` keyword added to _CreateSavedSearchesIngestV1_ operation.
+    - `foundry_logscale.py`
+    > Unit testing expanded to complete code coverage.
+    - `tests/test_foundry_logscale.py`
 
 ## Issues resolved
-+ Fixed: _update_policy_container_ operation payload handler is missing the `policy_id`` key. Closes #1068.
++ Fixed: _update_policy_container_ operation payload handler is missing the `policy_id` key. Closes #1068.
     - `_payload/_firewall.py`
     > Expanded unit testing to complete code coverage.
     - `tests/test_firewall_management.py`
diff --git a/src/falconpy/foundry_logscale.py b/src/falconpy/foundry_logscale.py
index 8e7ff3bb7..60c3d1c79 100644
--- a/src/falconpy/foundry_logscale.py
+++ b/src/falconpy/foundry_logscale.py
@@ -36,7 +36,7 @@
 For more information, please refer to <https://unlicense.org>
 """
 from typing import Dict, Union
-from ._util import force_default, process_service_request
+from ._util import force_default, process_service_request, handle_single_argument
 from ._payload import foundry_execute_search_payload, foundry_dynamic_search_payload
 from ._service_class import ServiceClass
 from ._endpoint._foundry_logscale import _foundry_logscale_endpoints as Endpoints
@@ -282,13 +282,15 @@ def execute(self: object,
             params=parameters
             )
 
-    def populate(self: object) -> Dict[str, Union[int, dict]]:
+    @force_default(defaults=["parameters"], default_types=["dict"])
+    def populate(self: object, *args, parameters: dict = None, **kwargs) -> Dict[str, Union[int, dict]]:
         """Populate a saved search.
 
         Keyword arguments:
-        This method does not accept keyword arguments.
+        app_id -- Application ID. String.
 
-        This method does not accept arguments.
+        Arguments: When not specified, the first argument to this method is assumed to be 'app_id'.
+                   All others are ignored.
 
         Returns: dict object containing API response.
 
@@ -300,7 +302,9 @@ def populate(self: object) -> Dict[str, Union[int, dict]]:
         return process_service_request(
             calling_object=self,
             endpoints=Endpoints,
-            operation_id="CreateSavedSearchesIngestV1"
+            operation_id="CreateSavedSearchesIngestV1",
+            keywords=kwargs,
+            params=handle_single_argument(args, parameters, "app_id")
             )
 
     @force_default(defaults=["parameters"], default_types=["dict"])
diff --git a/tests/test_foundry_logscale.py b/tests/test_foundry_logscale.py
index 3d6e12d04..97972ca59 100644
--- a/tests/test_foundry_logscale.py
+++ b/tests/test_foundry_logscale.py
@@ -29,7 +29,7 @@ def run_all_tests(self):
             "CreateSavedSearchesDynamicExecuteV1" : falcon.execute_dynamic(end="10", start="1"),
             "GetSavedSearchesExecuteV1" : falcon.get_search_results(job_id="12345"),
             "CreateSavedSearchesExecuteV1" : falcon.execute(search_parameters={"something": "somethingElse"}, end="10", start="1"),
-            "CreateSavedSearchesIngestV1" : falcon.populate(),
+            "CreateSavedSearchesIngestV1" : falcon.populate(app_id="pommegranate"),
             "GetSavedSearchesJobResultsDownloadV1" : falcon.download_results(job_id="12345", result_format="json"),
         }
         for key in tests: