From a227aea117a54fca01b97e7494d6432d2117fb2a Mon Sep 17 00:00:00 2001
From: Dirk Peter <67102395+dirk-peter-sag@users.noreply.github.com>
Date: Wed, 12 Jun 2024 12:09:29 +0200
Subject: [PATCH] #10 indicator tooltip and visibility (#23)

* #10: sets indicator tooltip

* #10: improves indicator visibility

* #10: moves update timer to service

---------

Co-authored-by: Dirk Peter <dirk.peter@softwareg.com>
---
 .../reminder-drawer.component.ts              | 22 -----------
 .../reminder-indicator.component.html         |  3 +-
 .../reminder-indicator.component.less         |  6 +--
 .../reminder-indicator.component.ts           | 32 +++++++++++++---
 .../reminder-modal.component.html             | 21 ++++++----
 .../reminder-modal.component.ts               | 13 +++----
 plugin/reminder-plugin.module.ts              |  4 +-
 plugin/services/reminder.service.ts           | 38 ++++++++++++++++++-
 8 files changed, 90 insertions(+), 49 deletions(-)

diff --git a/plugin/components/reminder-drawer/reminder-drawer.component.ts b/plugin/components/reminder-drawer/reminder-drawer.component.ts
index 0a87462..f433ca2 100644
--- a/plugin/components/reminder-drawer/reminder-drawer.component.ts
+++ b/plugin/components/reminder-drawer/reminder-drawer.component.ts
@@ -1,7 +1,5 @@
 import { Component, OnDestroy } from '@angular/core';
 import { AlertService, HeaderService } from '@c8y/ngx-components';
-import { filter, sortBy } from 'lodash';
-import moment from 'moment';
 import { BsModalService } from 'ngx-bootstrap/modal';
 import { BehaviorSubject, Subscription } from 'rxjs';
 import {
@@ -119,25 +117,5 @@ export class ReminderDrawerComponent implements OnDestroy {
     this.reminders = reminders;
     this.reminderGroups = this.reminderService.groupReminders(reminders);
     this.lastUpdate = new Date();
-    this.setUpdateTimer();
-  }
-
-  private setUpdateTimer(): void {
-    // TODO update indicator
-    // - move update timer to service?
-    const now = moment();
-
-    clearTimeout(this.updateTimer);
-
-    if (!this.reminders.length) return;
-
-    const closestReminder = sortBy(
-      filter(this.reminders, (r) => r.status !== ReminderStatus.cleared && moment(r.time) > now),
-      'time'
-    )[0];
-
-    if (!closestReminder) return;
-
-    this.updateTimer = setTimeout(() => this.digestReminders(this.reminders), moment(closestReminder.time).diff(now));
   }
 }
diff --git a/plugin/components/reminder-indicator/reminder-indicator.component.html b/plugin/components/reminder-indicator/reminder-indicator.component.html
index f8e6fba..43022a6 100644
--- a/plugin/components/reminder-indicator/reminder-indicator.component.html
+++ b/plugin/components/reminder-indicator/reminder-indicator.component.html
@@ -1,4 +1,5 @@
-<button type="button" class="{{ status }}" [class.open]="open" (click)="toggleDrawer()">
+<button type="button" class="{{ status }}" [tooltip]="tooltipText" [class.open]="open"
+  (click)="toggleDrawer()">
   <em>
     <ng-container *ngIf="open; else showText">
       <i [c8yIcon]="'close'"></i>
diff --git a/plugin/components/reminder-indicator/reminder-indicator.component.less b/plugin/components/reminder-indicator/reminder-indicator.component.less
index c69ba45..935e982 100644
--- a/plugin/components/reminder-indicator/reminder-indicator.component.less
+++ b/plugin/components/reminder-indicator/reminder-indicator.component.less
@@ -15,7 +15,7 @@ em {
   font-size: 16px;
   border-radius: 8px;
   background-color: var(--c8y-palette-status-success-light);
-  border: 0 solid var(--c8y-palette-status-success-light);
+  border: 1px solid var(--c8y-palette-status-success);
   transition: all .3s ease-in-out;
 }
 
@@ -35,13 +35,13 @@ button {
   background: none;
 
   &.status-warning em {
-    border-color: var(--c8y-palette-status-warning-high);
     background-color: var(--c8y-palette-status-warning-high);
+    border-color: var(--c8y-palette-status-warning);
   }
 
   &.status-danger em {
-    border-color: var(--c8y-palette-status-danger-light);
     background-color: var(--c8y-palette-status-danger-light);
+    border-color: var(--c8y-palette-status-danger);
   }
 
   &.open em {
diff --git a/plugin/components/reminder-indicator/reminder-indicator.component.ts b/plugin/components/reminder-indicator/reminder-indicator.component.ts
index 1b1a175..4f4d81b 100644
--- a/plugin/components/reminder-indicator/reminder-indicator.component.ts
+++ b/plugin/components/reminder-indicator/reminder-indicator.component.ts
@@ -2,27 +2,29 @@ import { Component, OnDestroy, OnInit } from '@angular/core';
 import { REMINDER_MAX_COUNTER } from '../../reminder.model';
 import { ReminderService } from '../../services/reminder.service';
 import { Subscription } from 'rxjs';
+import { TranslateService } from '@ngx-translate/core';
 
 const ReminderStatus = {
   default: '',
   warning: 'status-warning',
-  danger: 'status-danger',
+  danger: 'status-danger'
 };
 
 @Component({
   selector: 'c8y-reminder-indicator',
   templateUrl: './reminder-indicator.component.html',
-  styleUrls: ['./reminder-indicator.component.less'],
+  styleUrls: ['./reminder-indicator.component.less']
 })
 export class ReminderIndicatorComponent implements OnInit, OnDestroy {
   open = false;
   counter = 0;
   status = ReminderStatus.default;
   maxCounter = REMINDER_MAX_COUNTER;
+  tooltipText!: string;
 
   private subscription = new Subscription();
 
-  constructor(private reminderService: ReminderService) { }
+  constructor(private reminderService: ReminderService, private translateService: TranslateService) {}
 
   ngOnInit(): void {
     // open status
@@ -34,7 +36,10 @@ export class ReminderIndicatorComponent implements OnInit, OnDestroy {
 
     // reminder counter
     this.subscription.add(
-      this.reminderService.reminderCounter$.subscribe((counter) => this.setCounterStatus(counter))
+      this.reminderService.reminderCounter$.subscribe((counter) => {
+        this.setCounterStatus(counter);
+        this.setCounterText();
+      })
     );
   }
 
@@ -46,11 +51,28 @@ export class ReminderIndicatorComponent implements OnInit, OnDestroy {
     this.reminderService.toggleDrawer();
   }
 
-  private setCounterStatus(counter: number) {
+  private setCounterStatus(counter: number): void {
     this.counter = counter;
 
     if (counter >= this.maxCounter) this.status = ReminderStatus.danger;
     else if (counter >= 1) this.status = ReminderStatus.warning;
     else this.status = ReminderStatus.default;
   }
+
+  private setCounterText(counter = this.counter): void {
+    let txt: string;
+
+    switch (counter) {
+      case 0:
+        txt = 'No reminder is due';
+        break;
+      case 1:
+        txt = 'One reminder is due';
+        break;
+      default:
+        txt = '{{ counter }} reminders are due';
+    }
+
+    this.tooltipText = this.translateService.instant(txt, { counter });
+  }
 }
diff --git a/plugin/components/reminder-modal/reminder-modal.component.html b/plugin/components/reminder-modal/reminder-modal.component.html
index b75687d..6eebcea 100644
--- a/plugin/components/reminder-modal/reminder-modal.component.html
+++ b/plugin/components/reminder-modal/reminder-modal.component.html
@@ -4,14 +4,19 @@ <h3 translate>Create a Reminder</h3>
 
 <form [formGroup]="form" (submit)="submit()">
   <div class="modal-body">
-    <c8y-asset-selector-miller class="m-b-24" [label]="'Assign to'" [selectedDevice]="asset" [isLoading]="isLoading"
-      (onSelected)="assetSelected($event.items)" [config]="{
-      groupsSelectable: true,
-      singleColumn: true,
-      columnHeaders: true,
-      showFilter: true,
-      search: true
-    }"></c8y-asset-selector-miller>
+    <c8y-asset-selector-miller class="m-b-24"
+      [label]="'Assign to'"
+      [selectedDevice]="asset"
+      [isLoading]="isLoading"
+      [config]="{
+        groupsSelectable: true,
+        singleColumn: true,
+        columnHeaders: true,
+        showFilter: true,
+        search: true
+      }"
+      (onSelected)="assetSelected($event.items)"
+    ></c8y-asset-selector-miller>
 
     <formly-form [form]="form" [fields]="fields" [model]="reminder"></formly-form>
   </div>
diff --git a/plugin/components/reminder-modal/reminder-modal.component.ts b/plugin/components/reminder-modal/reminder-modal.component.ts
index 7f4a4a9..9f9b805 100644
--- a/plugin/components/reminder-modal/reminder-modal.component.ts
+++ b/plugin/components/reminder-modal/reminder-modal.component.ts
@@ -16,16 +16,15 @@ import { Reminder, ReminderStatus, REMINDER_TEXT_LENGTH, REMINDER_TYPE } from '.
   styleUrls: ['./reminder-modal.component.less']
 })
 export class ReminderModalComponent implements OnInit {
-  // TODO selectable context
   isLoading = false;
   asset!: Partial<IManagedObject>;
   form = new FormGroup({});
 
   reminder: Partial<Reminder> = {
-    // source: {
-    //   id: undefined,
-    //   name: undefined
-    // },
+    source: {
+      id: undefined,
+      name: undefined
+    },
     text: undefined,
     time: undefined,
     type: REMINDER_TYPE
@@ -75,8 +74,6 @@ export class ReminderModalComponent implements OnInit {
 
   ngOnInit(): void {
     this.asset = this.getAssetFromRoute(this.activatedRoute.snapshot);
-    // this.reminder.source.id = this.asset.id;
-    // this.reminder.source.name = String(this.asset.name) || '';
   }
 
   close() {
@@ -84,6 +81,8 @@ export class ReminderModalComponent implements OnInit {
   }
 
   assetSelected(asset: Partial<IManagedObject>): void {
+    if (!asset || !asset.id) return;
+
     this.asset = {
       id: asset.id,
       name: asset.name
diff --git a/plugin/reminder-plugin.module.ts b/plugin/reminder-plugin.module.ts
index 8150305..bae2903 100644
--- a/plugin/reminder-plugin.module.ts
+++ b/plugin/reminder-plugin.module.ts
@@ -4,6 +4,7 @@ import { RouterModule } from '@angular/router';
 import { CoreModule, EventRealtimeService, hookAction } from '@c8y/ngx-components';
 import { AssetSelectorModule } from '@c8y/ngx-components/assets-navigator';
 import { FormlyModule } from '@ngx-formly/core';
+import { TooltipModule } from 'ngx-bootstrap/tooltip';
 import { MomentModule } from 'ngx-moment';
 import { ReminderDrawerComponent } from './components/reminder-drawer/reminder-drawer.component';
 import { ReminderIndicatorComponent } from './components/reminder-indicator/reminder-indicator.component';
@@ -21,7 +22,8 @@ import { ReminderService } from './services/reminder.service';
     MomentModule,
     FormlyModule.forChild({
       types: [{ name: 'time', component: TimeFieldType }]
-    })
+    }),
+    TooltipModule
   ],
   declarations: [ReminderDrawerComponent, ReminderIndicatorComponent, ReminderModalComponent, TimeFieldType],
   providers: [
diff --git a/plugin/services/reminder.service.ts b/plugin/services/reminder.service.ts
index ee2f474..61018dd 100644
--- a/plugin/services/reminder.service.ts
+++ b/plugin/services/reminder.service.ts
@@ -1,10 +1,10 @@
 import { ComponentRef, Injectable } from '@angular/core';
 import { EventService, IEvent, IResult } from '@c8y/client';
 import { EventRealtimeService, RealtimeMessage } from '@c8y/ngx-components';
-import { cloneDeep, has, sortBy } from 'lodash';
+import { cloneDeep, filter as _filter, has, sortBy } from 'lodash';
 import moment from 'moment';
 import { BehaviorSubject, Subscription } from 'rxjs';
-import { filter, map } from 'rxjs/operators';
+import { map, filter } from 'rxjs/operators';
 import { ReminderDrawerComponent } from '../components/reminder-drawer/reminder-drawer.component';
 import {
   Reminder,
@@ -25,6 +25,7 @@ export class ReminderService {
   private drawerRef: ComponentRef<unknown>;
   private drawer: ReminderDrawerComponent;
   private subscription = new Subscription();
+  private updateTimer: NodeJS.Timeout;
   private _reminderCounter = 0;
   private _reminders: Reminder[] = [];
 
@@ -34,6 +35,8 @@ export class ReminderService {
   private set reminders(reminders: Reminder[]) {
     this._reminders = reminders;
     this.reminders$.next(this._reminders);
+    this.updateCounter();
+    this.setUpdateTimer();
   }
 
   private get reminderCounter(): number {
@@ -250,4 +253,35 @@ export class ReminderService {
       return reminder;
     });
   }
+
+  private updateCounter(): void {
+    const now = new Date().getTime();
+    let count = 0;
+    let dueDate: number;
+
+    this.reminders.forEach((reminder) => {
+      dueDate = new Date(reminder.time).getTime();
+      if (dueDate <= now && reminder.status === ReminderStatus.active) count++;
+    });
+
+    this.reminderCounter = count;
+  }
+
+  private setUpdateTimer(): void {
+    const now = moment();
+
+    clearTimeout(this.updateTimer);
+
+    if (!this.reminders || !this.reminders.length) return;
+
+    const dueReminders = _filter(this.reminders, (r) => r.status !== ReminderStatus.cleared && moment(r.time) > now);
+    const closestReminder: Reminder = sortBy(dueReminders, 'time')[0];
+
+    if (!closestReminder) return;
+
+    this.updateTimer = setTimeout(
+      () => (this.reminders = this.digestReminders(this.reminders)),
+      moment(closestReminder.time).diff(now)
+    );
+  }
 }