Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync nullable attributes with Cluster API #7

Closed
WilliamDEdwards opened this issue Oct 22, 2022 · 3 comments
Closed

Sync nullable attributes with Cluster API #7

WilliamDEdwards opened this issue Oct 22, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@WilliamDEdwards
Copy link
Contributor

WilliamDEdwards commented Oct 22, 2022

The attributes that are marked as nullable and non-nullable are out of sync between the Cluster API and the client. Every attribute should be checked and updated if needed.

@WilliamDEdwards WilliamDEdwards added the bug Something isn't working label Oct 22, 2022
@dvdheiden
Copy link
Collaborator

dvdheiden commented Oct 23, 2022

To fully match the objects in the Cluster API, we could consider using the create/update models from the Cluster API. Right now, the models in this package represent the entity (i.e. VirtualHost) and are used for all CRUD actions.

That will be a breaking change, so let's discuss this first.

@WilliamDEdwards
Copy link
Contributor Author

When doing the major version increase, change all references to Cluster API to Core API (what I wanted to do in #114).

@WilliamDEdwards
Copy link
Contributor Author

Will be automatically fixed by #117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants