Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependencies of type=zip to dependency-graph #331

Closed
t-kulmburg opened this issue Aug 23, 2023 · 2 comments
Closed

Add dependencies of type=zip to dependency-graph #331

t-kulmburg opened this issue Aug 23, 2023 · 2 comments

Comments

@t-kulmburg
Copy link

We have quite a lot of internal dependencies in our projects where we have a zip file as artifact (using @zip as extension in the dependencies block in build.gradle).

Using this plugin, this dependencies are correctly included in the bom file with ?type=zip.

Also in dependency-track, they are correctly shown in the Components tab.

However, when using Show in dependency graph in dependency-track, the root of the graph is shown with Dependency could not be found in dependency graph displayed above.

I had a quick look through the generation of the graph in the code and found that here and here the dependencies and child dependencies are only added to the graph if the type is either jar or aar.

To get a more complete graph I would propose to also add dependencies of other types to the dependency-graph.

zkstchhh added a commit to zkstchhh/cyclonedx-gradle-plugin that referenced this issue Mar 27, 2024
zkstchhh added a commit to zkstchhh/cyclonedx-gradle-plugin that referenced this issue Mar 27, 2024
Signed-off-by: Kai Zhuo <kai.zhuo@stiwa.com>
glefloch pushed a commit that referenced this issue Apr 23, 2024
Signed-off-by: Kai Zhuo <kai.zhuo@stiwa.com>
@skhokhlov
Copy link
Member

done in #413

Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants