Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bowl of Promises tiers not crafting correctly on servers #1039

Closed
XeramHosting opened this issue Jul 28, 2024 · 3 comments
Closed

Bowl of Promises tiers not crafting correctly on servers #1039

XeramHosting opened this issue Jul 28, 2024 · 3 comments

Comments

@XeramHosting
Copy link

Issue type:

  • 🐛 Bug

Short description:

When trying to craft different tiers of Bowl of Promises using the correct tiers of promises the craft doesn't go through as expected and instead crafts Tier 1 every time.

Steps to reproduce the problem:

  1. Make a bowl of dusted promises
  2. Make a Promise of Tenacity 2 or higher
  3. Throw both into a blood infuser with the right amount of blood
  4. Get a Tier 1 bowl

Expected behaviour:

The result of the afforementioned craft should be a tier 2 bowl but it consistently produces a tier 1 bowl until the server is restarted. This does not seem to happen on a SP world as far as I could tell, and does happen with just EvilCraft and it's dependencies installed.


Versions:

  • This mod: 47.3.5
  • Minecraft: 1.20.1
  • Forge: 1.2.43

Log file:

@rubensworks
Copy link
Member

Thanks for reporting!

@rubensworks
Copy link
Member

rubensworks commented Jul 29, 2024

This should not be possible due to this piece of code: https://github.com/CyclopsMC/EvilCraft/blob/master-1.20-lts/src/main/java/org/cyclops/evilcraft/blockentity/BlockEntityBloodInfuser.java#L154-L155

Do you by any chance have some mod in your pack that interacts with or modifies how minecraft handles recipes, such as a caching mechanism? Because this could break things if that mod does not correctly check the inventory.

In any case, can you try reproducing the problem without any other mods installed? (I could not on my end)
If it can't be reproduced, I recommend looking for the mod that breaks things, and report it to their issue tracker.

GitHub
An evil mod for Minecraft. Contribute to CyclopsMC/EvilCraft development by creating an account on GitHub.

@rubensworks rubensworks moved this from To Do to On hold (awaiting input) in Maintenance Jul 29, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 13, 2024
@github-project-automation github-project-automation bot moved this from On hold (awaiting input) to Done in Maintenance Aug 13, 2024
@KakashoLin
Copy link

KakashoLin commented Jan 7, 2025

If you are also using https://www.curseforge.com/minecraft/mc-mods/recipe-essentials-forge-fabric, it might not be compatible.

CurseForge
Essential fixes and improvements around recipes and crafting 20.0M Downloads | Mods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants