Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item Importer Predicate does not respect Round Robin #288

Closed
Telmooo opened this issue Apr 15, 2024 · 1 comment
Closed

Item Importer Predicate does not respect Round Robin #288

Telmooo opened this issue Apr 15, 2024 · 1 comment

Comments

@Telmooo
Copy link

Telmooo commented Apr 15, 2024

Issue type:

  • 🐛 Bug

Short description:

Item Importer with an “Import Items Predicate” does not respect Round Robin option.

Steps to reproduce the problem:

  1. Create a network with 3 chests, with following layout
C2
C1 C3
  1. Chest 1 & 2 have Item Interfaces (default settings).
  2. Chest 3 has an Item Importer.
  3. Create a Predicate (e.g. Operator :: Item Enchantable), and put in Item Importer with Round Robin active.
  4. Fill Chest 3 with Enchanted Items (e.g. Enchanted Armor piece)
  5. All the items get placed into Chest 2.

Expected behaviour:

Items should be split evenly between Chest 1 and Chest 2.

This expected behaviour is exactly what happens when using the "Import All Items" under the same setup.


Versions:

  • This mod: 1.8.26
  • Minecraft: 1.20.1
  • Forge: 47.2.20
  • Integrated Dynamics: 1.21.3

Log file:

None.

@rubensworks
Copy link
Member

Thanks for reporting!

rubensworks added a commit that referenced this issue Apr 28, 2024
This bug was introduced in 8f659ea
as a fix for #271. That commit enforced slot-based iteration over
the network, which ignores round-robin-based iterators. That fix
actually only needed to be applied to exporting, which is what this
commit does now.

Closes #288
@rubensworks rubensworks moved this to Done in Maintenance Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants