Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookie dialog has a strange text in current DSpace 8.1 Snapshot #3618

Closed
MW3000 opened this issue Nov 6, 2024 · 4 comments · Fixed by #3625
Closed

Cookie dialog has a strange text in current DSpace 8.1 Snapshot #3618

MW3000 opened this issue Nov 6, 2024 · 4 comments · Fixed by #3625
Assignees
@tdonohue
Labels
affects: 7.x Issue impacts 7.x releases affects: 8.x Issue impacts 8.x releases bug
Milestone
7.6.3

Comments

@MW3000
Copy link
Contributor

MW3000 commented Nov 6, 2024

Describe the bug

The text to the cookie dialog changed in the most recent DSpace 8.1 Snapshot. It now says:
"Hi! Could we please enable some additional services for ? You can always change or withdraw your consent later.”
I cannot find this string or a reference to klaro since this change happened

Screenshot 2024-11-06 at 19 44 52

To Reproduce

Steps to reproduce the behavior:

  1. Clear your browser cache and go to https://demo.dspace.org or run a local out of the box frontend

Expected behavior

I do not remember the old text, but it was a complete and more reasonable sentence. It should be reverted to the old text
@MW3000 MW3000 added bug needs triage New issue needs triage and/or scheduling labels Nov 6, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Nov 6, 2024
@tdonohue
Copy link
Member

tdonohue commented Nov 6, 2024

Fixed by #3586, which is waiting on reviews/testers

@tdonohue tdonohue mentioned this issue Nov 6, 2024
Closed
@tdonohue tdonohue added affects: 8.x Issue impacts 8.x releases affects: 7.x Issue impacts 7.x releases and removed needs triage New issue needs triage and/or scheduling labels Nov 6, 2024
@tdonohue tdonohue removed this from DSpace Backlog Nov 6, 2024
@tdonohue tdonohue moved this from 📋 To Do to 🏗 In Progress in DSpace 8.x and 7.6.x Maintenance Nov 6, 2024
@tdonohue tdonohue self-assigned this Nov 6, 2024
@MW3000
Copy link
Contributor Author

MW3000 commented Nov 6, 2024

Oh, sorry I missed the existing Issue. I tested your fix in DSpace 8 in worked. We can probably close this as a duplicate?

@tdonohue
Copy link
Member

tdonohue commented Nov 6, 2024

@MW3000 : I didn't create an issue ticket. I just created a PR immediately. So, we can leave this open, as I've already linked my PR up to it...that way this issue will auto-close when the PR is merged.

@tdonohue tdonohue mentioned this issue Nov 8, 2024
Merged
@tdonohue tdonohue linked a pull request Nov 8, 2024 that will close this issue
Fix Klaro translations by forcing Klaro to use a zy language code that DSpace will translate #3625
Merged
@tdonohue tdonohue added this to the 7.6.3 milestone Nov 8, 2024
@tdonohue
Copy link
Member

tdonohue commented Nov 8, 2024

Closing, fixed by #3625 and #3626

@tdonohue tdonohue closed this as completed Nov 8, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in DSpace 8.x and 7.6.x Maintenance Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdonohue tdonohue

Labels
affects: 7.x Issue impacts 7.x releases affects: 8.x Issue impacts 8.x releases bug
Projects
DSpace 8.x and 7.6.x Maintenance
Archived in project
Milestone
7.6.3
2 participants
@tdonohue @MW3000