Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reference to custom component in base component SuggestionListElementComponent #4040

Open
saschaszott opened this issue Feb 27, 2025 · 1 comment · May be fixed by #4041
Open

reference to custom component in base component SuggestionListElementComponent #4040

saschaszott opened this issue Feb 27, 2025 · 1 comment · May be fixed by #4041
Labels
affects: main Issue impacts "main" (latest release). affects: 8.x Issue impacts 8.x releases bug help wanted Needs a volunteer to claim to move forward

Comments

@saschaszott
Copy link
Contributor

Problem Description

SuggestionListElementComponent contains a reference to a custom component:

dspace-angular/src/app/notifications/suggestion-list-element/suggestion-list-element.component.ts

Line 13 in 52392ab

import { ItemSearchResultListElementComponent } from '../../../themes/custom/app/shared/object-list/search-result-list-element/item-search-result/item-types/item/item-search-result-list-element.component';

SuggestionListElementComponent should better use the base component (ItemSearchResultListElementComponent) in src/app/shared/object-list/search-result-list-element/item-search-result/item-types/item.
@saschaszott saschaszott changed the title reference to custom component in base component reference to custom component in base component SuggestionListElementComponent Feb 27, 2025
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Feb 27, 2025
@tdonohue tdonohue added bug help wanted Needs a volunteer to claim to move forward affects: main Issue impacts "main" (latest release). affects: 8.x Issue impacts 8.x releases labels Feb 27, 2025
@saschaszott saschaszott linked a pull request Feb 27, 2025 that will close this issue
Open
@saschaszott
Copy link
Contributor Author

This bug is fixed by PR #4041.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects: main Issue impacts "main" (latest release). affects: 8.x Issue impacts 8.x releases bug help wanted Needs a volunteer to claim to move forward
Projects
DSpace 8.x and 7.6.x Maintenance
Status: 📋 To Do
Milestone
No milestone
2 participants
@tdonohue @saschaszott