Site Rehaul. #18
Open
Site Rehaul. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,6 +54,7 @@ | |||
| t.string "last_sign_in_ip" | |||
| t.datetime "created_at" | |||
| t.datetime "updated_at" | |||
| t.string "name" | |||
There was a problem hiding this comment.
Any thoughts on keeping a first and last name instead of a full name field? If users are signing in via SSO (facebook, google), those already make the distinction between first and last so it wouldn't be any extra work to find it out.
There was a problem hiding this comment.
Yeah, that does seem better. I also want to do some real migration practice, so this could prove useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added some Facebook and Google OmniAuth things.
Reviewer: @nishadsingh1