Puppet 8 compatibility / puppet-lint

[siebrand]

puppet-lint issues in the module -- not all are puppet 8 blockers:

./datadog_agent/manifests/init.pp - WARNING: legacy fact 'operatingsystem' on line 435 (check: legacy_facts)
./datadog_agent/manifests/init.pp - WARNING: legacy fact 'operatingsystem' on line 487 (check: legacy_facts)
./datadog_agent/manifests/init.pp - WARNING: legacy fact 'operatingsystem' on line 506 (check: legacy_facts)
./datadog_agent/manifests/init.pp - WARNING: legacy fact 'operatingsystem' on line 526 (check: legacy_facts)
./datadog_agent/manifests/init.pp - WARNING: legacy fact 'operatingsystem' on line 762 (check: legacy_facts)
./datadog_agent/manifests/init.pp - WARNING: top scope fact instead of facts hash on line 435 (check: top_scope_facts)
./datadog_agent/manifests/init.pp - WARNING: top scope fact instead of facts hash on line 487 (check: top_scope_facts)
./datadog_agent/manifests/init.pp - WARNING: top scope fact instead of facts hash on line 506 (check: top_scope_facts)
./datadog_agent/manifests/init.pp - WARNING: top scope fact instead of facts hash on line 526 (check: top_scope_facts)
./datadog_agent/manifests/init.pp - WARNING: top scope fact instead of facts hash on line 762 (check: top_scope_facts)
./datadog_agent/manifests/install_integration.pp - WARNING: defined type not documented on line 1 (check: documentation)
./datadog_agent/manifests/integration.pp - WARNING: defined type not documented on line 1 (check: documentation)
./datadog_agent/manifests/integrations/directory.pp - WARNING: class not documented on line 57 (check: documentation)
./datadog_agent/manifests/integrations/directory.pp - WARNING: line has more than 140 characters on line 14 (check: 140chars)
./datadog_agent/manifests/integrations/directory.pp - WARNING: line has more than 140 characters on line 17 (check: 140chars)
./datadog_agent/manifests/integrations/directory.pp - WARNING: line has more than 140 characters on line 20 (check: 140chars)
./datadog_agent/manifests/integrations/directory.pp - WARNING: line has more than 140 characters on line 23 (check: 140chars)
./datadog_agent/manifests/integrations/directory.pp - WARNING: line has more than 140 characters on line 29 (check: 140chars)
./datadog_agent/manifests/integrations/haproxy.pp - WARNING: legacy fact 'ipaddress' on line 21 (check: legacy_facts)
./datadog_agent/manifests/integrations/haproxy.pp - WARNING: top scope fact instead of facts hash on line 21 (check: top_scope_facts)
./datadog_agent/manifests/integrations/http_check.pp - WARNING: class not documented on line 170 (check: documentation)
./datadog_agent/manifests/integrations/linux_proc_extras.pp - WARNING: class not documented on line 16 (check: documentation)
./datadog_agent/manifests/integrations/logs.pp - WARNING: class not documented on line 39 (check: documentation)
./datadog_agent/manifests/integrations/nginx.pp - WARNING: class not documented on line 62 (check: documentation)
./datadog_agent/manifests/integrations/ntp.pp - WARNING: class not documented on line 26 (check: documentation)
./datadog_agent/manifests/integrations/oom_kill.pp - WARNING: class not documented on line 22 (check: documentation)
./datadog_agent/manifests/integrations/php_fpm.pp - WARNING: class not documented on line 29 (check: documentation)
./datadog_agent/manifests/integrations/process.pp - WARNING: line has more than 140 characters on line 51 (check: 140chars)
./datadog_agent/manifests/integrations/rabbitmq.pp - WARNING: class not documented on line 53 (check: documentation)
./datadog_agent/manifests/integrations/snmp.pp - WARNING: class not documented on line 54 (check: documentation)
./datadog_agent/manifests/integrations/ssh.pp - WARNING: class not documented on line 29 (check: documentation)
./datadog_agent/manifests/integrations/ssh.pp - WARNING: legacy fact 'fqdn' on line 30 (check: legacy_facts)
./datadog_agent/manifests/integrations/ssh.pp - WARNING: top scope fact instead of facts hash on line 30 (check: top_scope_facts)
./datadog_agent/manifests/integrations/supervisord.pp - WARNING: class not documented on line 44 (check: documentation)
./datadog_agent/manifests/integrations/tcp_check.pp - WARNING: class not documented on line 88 (check: documentation)
./datadog_agent/manifests/params.pp - WARNING: class not documented on line 6 (check: documentation)
./datadog_agent/manifests/params.pp - WARNING: line has more than 140 characters on line 56 (check: 140chars)
./datadog_agent/manifests/params.pp - WARNING: legacy fact 'operatingsystem' on line 26 (check: legacy_facts)
./datadog_agent/manifests/params.pp - WARNING: legacy fact 'operatingsystem' on line 68 (check: legacy_facts)
./datadog_agent/manifests/params.pp - WARNING: top scope fact instead of facts hash on line 26 (check: top_scope_facts)
./datadog_agent/manifests/params.pp - WARNING: top scope fact instead of facts hash on line 68 (check: top_scope_facts)
./datadog_agent/manifests/redhat.pp - WARNING: class not documented on line 6 (check: documentation)
./datadog_agent/manifests/redhat.pp - WARNING: legacy fact 'operatingsystem' on line 27 (check: legacy_facts)
./datadog_agent/manifests/redhat.pp - WARNING: legacy fact 'operatingsystemrelease' on line 30 (check: legacy_facts)
./datadog_agent/manifests/redhat.pp - WARNING: legacy fact 'architecture' on line 48 (check: legacy_facts)
./datadog_agent/manifests/redhat.pp - WARNING: legacy fact 'architecture' on line 52 (check: legacy_facts)
./datadog_agent/manifests/redhat.pp - WARNING: legacy fact 'architecture' on line 56 (check: legacy_facts)
./datadog_agent/manifests/redhat.pp - WARNING: top scope fact instead of facts hash on line 27 (check: top_scope_facts)
./datadog_agent/manifests/redhat.pp - WARNING: top scope fact instead of facts hash on line 30 (check: top_scope_facts)
./datadog_agent/manifests/redhat.pp - WARNING: top scope fact instead of facts hash on line 48 (check: top_scope_facts)
./datadog_agent/manifests/redhat.pp - WARNING: top scope fact instead of facts hash on line 52 (check: top_scope_facts)
./datadog_agent/manifests/redhat.pp - WARNING: top scope fact instead of facts hash on line 56 (check: top_scope_facts)
./datadog_agent/manifests/reports.pp - WARNING: legacy fact 'operatingsystem' on line 32 (check: legacy_facts)
./datadog_agent/manifests/reports.pp - WARNING: top scope fact instead of facts hash on line 32 (check: top_scope_facts)
./datadog_agent/manifests/security_agent.pp - WARNING: class not documented on line 1 (check: documentation)
./datadog_agent/manifests/security_agent.pp - WARNING: legacy fact 'operatingsystem' on line 18 (check: legacy_facts)
./datadog_agent/manifests/security_agent.pp - WARNING: top scope fact instead of facts hash on line 18 (check: top_scope_facts)
./datadog_agent/manifests/service.pp - WARNING: class not documented on line 6 (check: documentation)
./datadog_agent/manifests/service.pp - WARNING: legacy fact 'operatingsystem' on line 13 (check: legacy_facts)
./datadog_agent/manifests/service.pp - WARNING: top scope fact instead of facts hash on line 13 (check: top_scope_facts)
./datadog_agent/manifests/suse.pp - WARNING: class not documented on line 6 (check: documentation)
./datadog_agent/manifests/suse.pp - WARNING: legacy fact 'architecture' on line 42 (check: legacy_facts)
./datadog_agent/manifests/suse.pp - WARNING: legacy fact 'operatingsystemmajrelease' on line 80 (check: legacy_facts)
./datadog_agent/manifests/suse.pp - WARNING: top scope fact instead of facts hash on line 42 (check: top_scope_facts)
./datadog_agent/manifests/suse.pp - WARNING: top scope fact instead of facts hash on line 80 (check: top_scope_facts)
./datadog_agent/manifests/system_probe.pp - WARNING: class not documented on line 8 (check: documentation)
./datadog_agent/manifests/system_probe.pp - WARNING: legacy fact 'operatingsystem' on line 35 (check: legacy_facts)
./datadog_agent/manifests/system_probe.pp - WARNING: top scope fact instead of facts hash on line 35 (check: top_scope_facts)
./datadog_agent/manifests/ubuntu.pp - WARNING: class not documented on line 6 (check: documentation)
./datadog_agent/manifests/ubuntu.pp - WARNING: legacy fact 'operatingsystem' on line 64 (check: legacy_facts)
./datadog_agent/manifests/ubuntu.pp - WARNING: legacy fact 'operatingsystemrelease' on line 64 (check: legacy_facts)
./datadog_agent/manifests/ubuntu.pp - WARNING: legacy fact 'operatingsystem' on line 65 (check: legacy_facts)
./datadog_agent/manifests/ubuntu.pp - WARNING: legacy fact 'operatingsystemrelease' on line 65 (check: legacy_facts)
./datadog_agent/manifests/ubuntu.pp - WARNING: top scope fact instead of facts hash on line 64 (check: top_scope_facts)
./datadog_agent/manifests/ubuntu.pp - WARNING: top scope fact instead of facts hash on line 64 (check: top_scope_facts)
./datadog_agent/manifests/ubuntu.pp - WARNING: top scope fact instead of facts hash on line 65 (check: top_scope_facts)
./datadog_agent/manifests/ubuntu.pp - WARNING: top scope fact instead of facts hash on line 65 (check: top_scope_facts)
./datadog_agent/manifests/windows.pp - WARNING: class not documented on line 6 (check: documentation)
./datadog_agent/manifests/windows.pp - WARNING: line has more than 140 characters on line 48 (check: 140chars)

[flepoutre]

Hi,
Any news on this issue ?
Thanks

[mjprinvale]

Also looking for updates on this.

[sa-dbilling]

Any idea when Puppet 8 support will be added?

[xenon8]

This is being worked on in this pr: #823

[ardrigh]

Appreciate the work on getting Puppet 8 support added.

This will be a blocker for a lot of customer upgrades, with the Puppet 7 and Puppet Enterprise LTS overlap/extended support ending at end of February 2025: https://www.puppet.com/products/puppet-enterprise/support-lifecycle