Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message after merging branch but not deleting #15

Open
haensch-mauricio opened this issue Feb 27, 2019 · 0 comments
Open

Improve message after merging branch but not deleting #15

haensch-mauricio opened this issue Feb 27, 2019 · 0 comments
Labels

Comments

@haensch-mauricio
Copy link

When merging a branch that cannot be deleted because of some reason, the only output is an exception message of "cannot delete branch", with no hints that the merge itself was successful.

To illustrate, this was my workflow:

I had 3 branches: A, B and C and two open PRs: A <- B and B <- C

I tried doing a !merge B and got only this message:

Computer says nooo. See logs for details:
400: {'errors': [{'context': 'name', 'message': 'You cannot delete this branch since it has at least one open pull request associated with it', 'exceptionName': 'com.atlassian.bitbucket.internal.branch.UnsupportedOnBranchException'}]}

At first I thought that the merge didn't occur since no confirmation showed up, so I changed the target of my PR 2 to be A <- C and used the same command again, !merge B and this time got this message:

No pull request open for this branch!

Then I confirmed and the merge was really done, I believe it is just question of improving the output when an exception occurs.

@nicoddemus nicoddemus added the bug label Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants