Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voxlap Refactored: 6.1 #23

Open
Ericson2314 opened this issue Apr 4, 2013 · 6 comments
Open

Voxlap Refactored: 6.1 #23

Ericson2314 opened this issue Apr 4, 2013 · 6 comments

Comments

@Ericson2314
Copy link
Owner

After this is done I can't mutate the history so I rather do it after the initial port. :)

@Lensman
Copy link

Lensman commented Apr 5, 2013

Making progress here, but the global variables are making it tricky. I've started pegging them to their associated functions in the hope that we can have a clear understanding of what they all do, and where they get used. Do you have any experience with IDA pro? I already have a half formed signature file from stuff I was working on before, which may come in handy for debugging. Maybe we can discuss on IRC sometime.

@Ericson2314
Copy link
Owner Author

I have used IDA a bit, so feel free to consider that. And with this I've flipped again. it's fine to refactor now, but when we are done and have a testing suit I may redo the history on an entirely new branch so that no commit breaks any tests.

So yeah, TL;DR what you are doing on conservative is great.

@Lensman
Copy link

Lensman commented Apr 6, 2013

I understand what you mean there, something with this many shared globals will need to be treated with kid gloves once it's 'working'.

@Ericson2314
Copy link
Owner Author

Hey @Lensman, haven't heard from you in a while. Are you still interested in working on Voxlap when I have time again mid May?

@Ericson2314
Copy link
Owner Author

@Lensman Oh, for some reason github wasn't notifying me that you had pushed to your re-factored repository. Now that you got a good deal of progress in there, do you think we could rebase off my initial commit? the first dump in the repo makes for kind of a drastic commit, so if we could retroactively redo that process and then rebase what you have I think that would be best.

@Ericson2314
Copy link
Owner Author

And are you using CMake to build? If so great, I am sick of maintaining multiple Makefiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants