From 745f6e3a8f2d2101471a55c65f378419fcb774d7 Mon Sep 17 00:00:00 2001 From: Discookie Date: Wed, 2 Nov 2022 02:22:51 +0100 Subject: [PATCH 1/2] Use Tests action as dependency in Deploy action --- .github/workflows/deploy.yml | 8 +++----- .github/workflows/test.yml | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 3495fa8..43af230 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -6,9 +6,12 @@ on: types: [published] jobs: + test: + uses: ./.github/workflows/test.yml build: name: Create extension runs-on: ubuntu-18.04 + needs: [test] # Each registry should have the following fields: # - name: unique extension id. @@ -39,11 +42,6 @@ jobs: - name: Install dependencies run: yarn install --frozen-lockfile - - name: Run tests - uses: GabrielBB/xvfb-action@v1.0 - with: - run: yarn run test - - name: Get the version id: get_version run: echo ::set-output name=VERSION::${GITHUB_REF#refs/tags/} diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index f1d0473..8d7433c 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -1,7 +1,7 @@ name: codechecker-vscodeplugin-tests # Triggers the workflow on push or pull request events. -on: [push, pull_request] +on: [push, pull_request, workflow_call] jobs: test: From 0501ac82783c4e1a11f426cc44e22e292d20d025 Mon Sep 17 00:00:00 2001 From: Discookie Date: Thu, 3 Nov 2022 12:31:36 +0100 Subject: [PATCH 2/2] Update Actions versions * Host system: Ubuntu 18 -> 22 * Node 12 -> 16 * Checkout v2 -> v3 --- .github/workflows/deploy.yml | 6 +++--- .github/workflows/test.yml | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 43af230..acf52a9 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -10,7 +10,7 @@ jobs: uses: ./.github/workflows/test.yml build: name: Create extension - runs-on: ubuntu-18.04 + runs-on: ubuntu-22.04 needs: [test] # Each registry should have the following fields: @@ -32,12 +32,12 @@ jobs: steps: - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Install Node.js uses: actions/setup-node@v1 with: - node-version: 12.x + node-version: 16.x - name: Install dependencies run: yarn install --frozen-lockfile diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 8d7433c..1d177a3 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -6,9 +6,9 @@ on: [push, pull_request, workflow_call] jobs: test: name: Tests - runs-on: ubuntu-18.04 + runs-on: ubuntu-22.04 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Install dependencies run: yarn install --frozen-lockfile - name: Install CodeChecker @@ -18,6 +18,6 @@ jobs: sudo snap alias codechecker CodeChecker CodeChecker version - name: Run tests - uses: GabrielBB/xvfb-action@v1.0 + uses: GabrielBB/xvfb-action@v1.6 with: run: yarn run test