Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to generate test targets #9

Open
JesseTatasciore opened this issue Jan 23, 2020 · 4 comments
Open

Add the ability to generate test targets #9

JesseTatasciore opened this issue Jan 23, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@JesseTatasciore
Copy link
Contributor

JesseTatasciore commented Jan 23, 2020

When there are test files present, it would be useful to generate the targets necessary to run those tests

@mattem
Copy link
Contributor

mattem commented Jan 23, 2020

Does the functionality exist in our previous version of gen internally? I think it generated the ts_web_test and ng_web_test macros.

Do we still want that here or should it gen a ts_library and thekarma_web_test_suite?

@mattem mattem added the enhancement New feature or request label Jan 24, 2020
@JesseTatasciore
Copy link
Contributor Author

Yes our previous internal version generated for the macros. I would be inclined to say macro. Allows for mass customization of targets / what if someone wants an additional target for whatever reason. Leaves the implementation out of our hands

@mattem
Copy link
Contributor

mattem commented Jan 24, 2020

Seems reasonable, we should look to add ng_web_test and ts_web_test to the index.bzl here. I quite like those as macros anyway.

@Toxicable
Copy link
Contributor

So for our repository we use jasmine_node_test for all our unit testing, this includes both nodejs and browser targets.

Might be worth making it configurable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants