Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the macro definition -DVCD_OUTPUT (after the next release) #560

Open
zapta opened this issue Jan 27, 2025 · 0 comments
Open

Remove the macro definition -DVCD_OUTPUT (after the next release) #560

zapta opened this issue Jan 27, 2025 · 0 comments

Comments

@zapta
Copy link
Collaborator

zapta commented Jan 27, 2025

Background: When running apio test and apio sim, the iverolog command contains the macro definition -DVCD_OUTPUT=... for backward compatibly with old testbenches that use it with the function $dumpfile(). That use is not recomanded anymore (and apio emit a warning if it detects $dumpfile() in a testbench) since apio now sets that value in the vvp directly command line, eliminating a user error that will misplace the output file.

This issue is to remove the macro definition after the next apio release.

Also, change the warning to a fatal error.

f"Warning: [{file.name}] Using $dumpfile() in apio "

$ apio test
Setting the envinronment.
Processing board alhambra-ii
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Scanning for issues.
Testbench ledon_tb.v
iverilog -g2012 -o _build/ledon_tb.out -DVCD_OUTPUT=_build/ledon_tb -DNO_ICE40_DEFAULT_ASSIGNMENTS -I"/Users/user/.apio/packages/oss-cad-suite/share/yosys/ice40" "/Users/user/.apio/packages/oss-cad-suite/share/yosys/ice40/cells_sim.v" main.v ledon_tb.v
vvp _build/ledon_tb.out -dumpfile=_build/ledon_tb.vcd
VCD info: dumpfile _build/ledon_tb.vcd opened for output.
End of simulation
ledon_tb.v:38: $finish called at 100000 (1ps)
========================================================================== [SUCCESS] Took 0.38 seconds ==========================================================================
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant