Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap Next/Prev for time-based ordering to match Obsidian #18

Open
brendon-felix opened this issue Jan 27, 2025 · 3 comments · May be fixed by #21
Open

Swap Next/Prev for time-based ordering to match Obsidian #18

brendon-felix opened this issue Jan 27, 2025 · 3 comments · May be fixed by #21
Assignees
Labels
bug Something isn't working good first issue Good for newcomers question Further information is requested

Comments

@brendon-felix
Copy link
Contributor

brendon-felix commented Jan 27, 2025

My changes intentionally alter the behavior of creation time and modified time ordering since I believe they are backwards. This breaks the tests that failed in #17.

In Obsidian's file explorer, the normal ordering for created time and modified time is 'new to old' with reverse ordering being 'old to new'. In my opinion, the next/prev file commands should match the file explorer ordering. Users can always swap the hotkeys for next/prev if they would like to.

Originally posted by @brendon-felix in #17 (comment)

@FabianUntermoser
Copy link
Owner

Good find! I agree.

What do you think about naming the commands in a more helpful way, such as navigate to newer file for sorting based on the modification timestamp?

@FabianUntermoser FabianUntermoser added good first issue Good for newcomers question Further information is requested bug Something isn't working labels Jan 30, 2025
@brendon-felix
Copy link
Contributor Author

brendon-felix commented Jan 30, 2025

I do think that would make the commands more clear, especially with #17 merged. My understanding is that "Navigate to prev file (creation timestamp)" would be replaced with with "Navigate to newer file (creation timestamp)" and "Navigate to next file (creation timestamp)" would be replaced with with "Navigate to older file (creation timestamp)" and so on.

@FabianUntermoser
Copy link
Owner

Hey @brendon-felix, have a look at #21 to see if were on the same page. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers question Further information is requested
Projects
None yet
2 participants