Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version number to a parameter set #25

Closed
valentinsulzer opened this issue Feb 18, 2023 · 2 comments
Closed

Add version number to a parameter set #25

valentinsulzer opened this issue Feb 18, 2023 · 2 comments

Comments

@valentinsulzer
Copy link

Add version number to a parameter set, separate from (in addition to) the BPX version number.

This would allow us to fix mistakes or inaccuracies in parameter sets while maintaining old versions (and hence not changing any previous results/publications that have been obtained using an old version).

It can probably just be a single version number, doesn't need to be semantic versioning.

@rtimms
Copy link
Collaborator

rtimms commented Jun 28, 2024

Add a new field to the Header, e.g.

    version: str = Field(
        None,
        alias="Version",
        example="0.1.1",
        description="BPX file version",
    )

@Ubham16

@rtimms
Copy link
Collaborator

rtimms commented Jul 9, 2024

Fixed by #63

@rtimms rtimms closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants