Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #54

Closed
Gashmob opened this issue Dec 23, 2024 · 0 comments · Fixed by #55
Closed

Update dependencies #54

Gashmob opened this issue Dec 23, 2024 · 0 comments · Fixed by #55
Labels
dependencies Update/Change dependencies
Milestone

Comments

@Gashmob
Copy link
Member

Gashmob commented Dec 23, 2024

Update nix dependencies + pin

Move all bin scripts to tools/bin and add it to $PATH in nix-shell

@Gashmob Gashmob added the dependencies Update/Change dependencies label Dec 23, 2024
@Gashmob Gashmob added this to the v0.1.0 milestone Dec 23, 2024
Gashmob added a commit that referenced this issue Dec 27, 2024
Part of #54

Commit 3e889463e499537c602e3ea83da6e33f9dc974da

+ create pnpm derivation directly from version 9.15.1
@Gashmob Gashmob linked a pull request Dec 27, 2024 that will close this issue
Gashmob added a commit that referenced this issue Dec 28, 2024
Part of #54

`tools/bin` is added to $PATH when in nix-shell, so you can invoke the
script directly. Paths inside scripts are also now absolute and use var
$ROOT_DIR defined in nix-shell. So you need to be in nix-shell in order
to use scripts, else it may cause some troubles.
Gashmob added a commit that referenced this issue Dec 29, 2024
Part of #54

Instead of using FetchContent in cmake to download libraries, use
nix-shell to add them as dependencies. Cmake can then retrieve them.

When in nix-shell, nix store paths are already added to cmake vars. But
when using an IDE not aware of nix environment, we need to add it
manually -> line 4 to 9 in CMakeLists.txt are here for that
Gashmob added a commit that referenced this issue Dec 29, 2024
Part of #54

Instead of using FetchContent in cmake to download libraries, use
nix-shell to add them as dependencies. Cmake can then retrieve them.

When in nix-shell, nix store paths are already added to cmake vars. But
when using an IDE not aware of nix environment, we need to add it
manually -> line 4 to 9 in CMakeLists.txt are here for that
Gashmob added a commit that referenced this issue Dec 29, 2024
Part of #54

Instead of using FetchContent in cmake to download libraries, use
nix-shell to add them as dependencies. Cmake can then retrieve them.

When in nix-shell, nix store paths are already added to cmake vars. But
when using an IDE not aware of nix environment, we need to add it
manually -> line 4 to 9 in CMakeLists.txt are here for that
Gashmob added a commit that referenced this issue Dec 29, 2024
Part of #54

Instead of using FetchContent in cmake to download libraries, use
nix-shell to add them as dependencies. Cmake can then retrieve them.

When in nix-shell, nix store paths are already added to cmake vars. But
when using an IDE not aware of nix environment, we need to add it
manually -> line 4 to 9 in CMakeLists.txt are here for that
Gashmob added a commit that referenced this issue Dec 29, 2024
Part of #54

After the move of scripts in 9bbd82c,
package and tests workflow were updated in order to use new location but
not codeql. This commit fix this miss
Gashmob added a commit that referenced this issue Dec 29, 2024
Part of #54

With moving of dependencies, some ignores of lcov are not matched and
considered as errors

Also choose to ignore version errors
Gashmob added a commit that referenced this issue Jan 7, 2025
Part of #54

3e889463e499537c602e3ea83da6e33f9dc974da has a broken rpm/rpmbuild

eb28b94bd14835836b539bc3854a6abf929876d4 is previously used pin and it
works with it
Gashmob added a commit that referenced this issue Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update/Change dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant