Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Queues #2462

Open
wrtobin opened this issue May 18, 2023 · 4 comments
Open

Merge Queues #2462

wrtobin opened this issue May 18, 2023 · 4 comments
Assignees
Labels
type: build system Build system issue type: dev environment type: discussion Users discussions about the features of GEOS, ... type: feature New feature or request type: testing Unit tests, non-regression testing, ...

Comments

@wrtobin
Copy link
Collaborator

wrtobin commented May 18, 2023

Do we want to implement an actual merge train / merge queue solution to prevent the situation we often have now where branches in the PR Merge Order > Merge Queue have to merge-in previous merges and rerun the entire CI suite?

We would need to be more careful about merge order, and people would need to be aware of everything ahead of them in the merge queue to prevent possible merge conflicts, etc, so there is a slightly higher demand on developers, but if used properly could improve time-to-merge and reduce overall CI usage.

@wrtobin wrtobin added type: feature New feature or request type: testing Unit tests, non-regression testing, ... type: build system Build system issue type: dev environment type: new A new issue has been created and requires attention type: discussion Users discussions about the features of GEOS, ... labels May 18, 2023
@wrtobin wrtobin self-assigned this May 18, 2023
@wrtobin
Copy link
Collaborator Author

wrtobin commented May 18, 2023

... I suppose having CI that doesn't have issues with timing out is probably a prerequisite of this.

@untereiner
Copy link
Contributor

What about github's merge queue beta functionality ?

@wrtobin
Copy link
Collaborator Author

wrtobin commented Jun 15, 2023

Yeah that is more or less what this is about. It will requires discussions and planning here at Livermore though, and will require developers have a slightly different understanding of how the merge queue operates.

@TotoGaz TotoGaz removed the type: new A new issue has been created and requires attention label Jun 21, 2023
@untereiner
Copy link
Contributor

untereiner commented Mar 15, 2024

@TotoGaz @rrsettgast github merge queue is generally available . Would it be possible for you to enable this new branch protection ? And, only this one to put all accepted PR in the queue automatically ?
It would also help in the process of continuous delivery #3035

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: build system Build system issue type: dev environment type: discussion Users discussions about the features of GEOS, ... type: feature New feature or request type: testing Unit tests, non-regression testing, ...
Projects
None yet
Development

No branches or pull requests

3 participants