Incorrect Column Name in tessellate_subduction_zones Function

[singhsatyampratap]

Description:

In the PlateReconstruction.tessellate_subduction_zones(return_geodataframe=True) function, the returned DataFrame includes a column named overriding_plate_id. However, this column should be named trench_plate_id to accurately reflect the data it represents. The current overriding_plate_id values differ significantly from the trench plate IDs, as shown in the attached figure.

Steps to Reproduce:

1. Use the PlateReconstruction.tessellate_subduction_zones(return_geodataframe=True) function.
2. Inspect the returned DataFrame.

Please refer to the attached figure for a visual comparison of the overriding_plate_id and trench_plate_id.

Attachment:

[jcannon-gplates]

Yes, that's true, it probably should be changed to "trench plate ID" here. I don't think that'll cause a problem - if I don't hear from any @GPlates/gplately-dev then I'll change that next week.

Originally the subduction convergence script (previously in PlateTectonicTools) used to find the plate ID of the overriding plate, but was subsequently changed to the plate ID of the trench line for this reason.

[jcannon-gplates]

There's new functionality from #316 (using recent pygplates 1.0.0rc1 functionality) that affects this issue. However the trench plate IDs are still not quite correct yet (the new functionality, unlike the original functionality, is not accurate for deforming trenches) as noted here:

gplately/gplately/reconstruction.py

Lines 665 to 673 in ca4a898

	# TODO: Get trench plate ID from sub-segments of shared sub-segment (if it's a topological line).
	# This will probably require adding the sub-segment feature (or sub-sub-segment if topological line)
	# to pygplates.PlateBoundaryStatistic (so we can obtain the trench plate ID).
	# Perhaps can slip that into pygplates 1.0.0 (Jan 2025).
	# Until then this will not be accurate for deforming topological lines:
	# See https://github.com/GPlates/gplately/issues/270
	trench_plate_id = (
	shared_sub_segment.get_feature().get_reconstruction_plate_id()
	)

Just a note to myself: The fix mentioned in that TODO has now been added to pygplates and will be available in pygplates 1.0.0 (soon). So I'll update gplately to use the trench ID when that is officially released (soon), and will also rename the column to "trench plate ID" to close this issue.