Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haddocks for normal forms of boolean expressions #284

Open
langston-barrett opened this issue Feb 5, 2025 · 0 comments
Open

Haddocks for normal forms of boolean expressions #284

langston-barrett opened this issue Feb 5, 2025 · 0 comments

Comments

@langston-barrett
Copy link
Contributor

langston-barrett commented Feb 5, 2025

          I would argue that we should spell out the expectations for how boolean normalization should work here in the library Haddocks, not tucked away in the comments of a test suite. Do you agree?

Originally posted by @RyanGlScott in #277 (comment)

The task is to take the comments in test/Bool.hs and turn them into a comprehensive, numbered list of invariants. The checks in Bool.hs should then refer to the invariants by number. Above isNormal and below the list of invariants, we should put comments requesting that developers keep them in sync.

We should also note the motivation for these rewrites / normal forms: to reduce the sizes of terms, to keep terms more concrete, and (in the service of the first two) to keep terms in normal forms (e.g., so that they can be compared for equality, and rewrite rules can assume normal forms as inputs). We should describe how each invariant contributes to these goals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant