-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
term total nitrogen concentration (tot_nitro) is water specific, should be general #680
Comments
Actually, it looks like a separate slot was made to be less water specific... see https://genomicsstandardsconsortium.github.io/mixs/0000530/ I recommend deprecating tot_nitro and using tot_nitro_content |
will complete when deprecation protocol is in place |
The nuance of what is being measured, concentration vs % of nitrogen in the soil could be lost, if these two were combined. Reviewing the definitions: Note: two forms of Nitrogen are measured for soil: To measure total C and N, subsamples of dried, finely ground soil are weighed into small foil capsules that are combusted in an automated CHN analyzer that measures the amount of released CO2 and N2 by gas chromatography. Final values are expressed as the percentage of carbon or nitrogen in dry soil. |
Describe the bug
A clear and concise description of what the bug is.
The description of tot_nitro is : Total nitrogen concentration of water samples, calculated by: total nitrogen = total dissolved nitrogen + particulate nitrogen. Can also be measured without filtering, reported as nitrogen
The specification of water is limiting, you can have total N on all samples
this is used in extension
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Terms definitions will be general, not environment specific and slot usage can be added for specific environments
The text was updated successfully, but these errors were encountered: