Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the RuntimeIdentifiers property osx change to osx-x64? #201

Closed
Cricle opened this issue Jun 19, 2024 · 5 comments
Closed

Should the RuntimeIdentifiers property osx change to osx-x64? #201

Cricle opened this issue Jun 19, 2024 · 5 comments

Comments

@Cricle
Copy link
Contributor

Cricle commented Jun 19, 2024

<RuntimeIdentifiers>win-x64;linux-x64;linux-arm64;osx</RuntimeIdentifiers>

<MSBuild Projects="DownloadNativeLibs.targets" Properties="Rid=osx;LibUrl=$(DuckDbArtifactRoot)/libduckdb-osx-universal.zip" />

According to rid-catalog#macos osx-x64 is macOS RIDs

@Cricle
Copy link
Contributor Author

Cricle commented Jun 19, 2024

Drafted modifications on #202

@Giorgi
Copy link
Owner

Giorgi commented Jun 19, 2024

In that case I would need to have osx-x64 and osx-arm64 which probably means including libduckdb.dylib twice in the NuGet package.

@Cricle
Copy link
Contributor Author

Cricle commented Jun 19, 2024

When use osx in RuntimeIdentifiers property in publish with AOT option will throw this error

Error NETSDK1082: Microsoft. NETCore. App does not have a runtime package available for the specified RuntimeIdentifier 'osx'

The public PortableRuntimeIdentifierGraph in here

https://github.com/dotnet/sdk/blob/cfab4700816a8ace11b9b700a1d85b721c363d6a/src/Layout/redist/PortableRuntimeIdentifierGraph.json#L317-L333

I don't know if this OSX identity will continue to be used in the future, If this is an unimportant matter, please close this issue.

Thanks.

@Giorgi
Copy link
Owner

Giorgi commented Jun 19, 2024

I haven't looked into Native AOT yet. I'll close this issue and we can come back to it if needed.

@Cricle
Copy link
Contributor Author

Cricle commented Jun 19, 2024

Ok

@Giorgi Giorgi closed this as completed Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants