Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add original artifact name to TransformerContext #546

Open
grossws opened this issue Feb 6, 2020 · 2 comments
Open

Add original artifact name to TransformerContext #546

grossws opened this issue Feb 6, 2020 · 2 comments

Comments

@grossws
Copy link
Contributor

grossws commented Feb 6, 2020

Shadow Version

5.2.0

Gradle Version

6.1.1

Currently TransformerContext only relative path. For some transformers it would be helpful to have not only relative path but original artifact name to base decisions on that.

In my case I want to merge some files in particular order when assembling uber-jar to allow overriding configuration values in current artifact to be last in the merge. It's similar to how current AppendingTransformer works but with deferred joining. Then with current project dependency tree I can topologically sort entries before actually merging them.

If you have some other ideas how to get the same result without extending transformer context I'm eager to listen.

@grossws grossws changed the title Feature request: add original artifact name to TransformerContext [Feature request]: add original artifact name to TransformerContext Feb 6, 2020
@Goooler Goooler closed this as completed Mar 3, 2025
@Goooler
Copy link
Member

Goooler commented Mar 3, 2025

Will track discussions and details in #913.

@Goooler
Copy link
Member

Goooler commented Mar 3, 2025

My bad, reopen this as you requested to add the original jar names in TransformerContext instead of FileTreeElement, which is related to #913.

@Goooler Goooler reopened this Mar 3, 2025
@Goooler Goooler changed the title [Feature request]: add original artifact name to TransformerContext Add original artifact name to TransformerContext Mar 13, 2025
@Goooler Goooler changed the title Add original artifact name to TransformerContext Add original artifact name to TransformerContext Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants