Skip to content

Commit f625eaf

Browse files
s9y#844 Simplify code removing If statement because we escape term search anyway + change alias to mysqli_real_escape_string
1 parent 1c60209 commit f625eaf

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

include/db/mysqli.inc.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ function serendipity_db_matched_rows() {
189189
*/
190190
function serendipity_db_escape_string($string) {
191191
global $serendipity;
192-
return mysqli_escape_string($serendipity['dbConn'], $string);
192+
return mysqli_real_escape_string($serendipity['dbConn'], $string);
193193
}
194194

195195
/**

include/functions_entries.inc.php

+2-6
Original file line numberDiff line numberDiff line change
@@ -882,12 +882,8 @@ function &serendipity_searchEntries($term, $limit = '', $searchresults = '') {
882882
$cond['distinct'] = '';
883883
$term = str_replace('"', '"', $term);
884884
$relevance_enabled = true;
885-
if (preg_match('@["\+\-\*~<>\(\)]+@', $term)) {
886-
$term = serendipity_db_escape_string($term);
887-
$cond['find_part'] = "MATCH(title,body,extended) AGAINST('\"$term\"' IN BOOLEAN MODE)";
888-
} else {
889-
$cond['find_part'] = "MATCH(title,body,extended) AGAINST('$term')";
890-
}
885+
$term = serendipity_db_escape_string($term);
886+
$cond['find_part'] = "MATCH(title,body,extended) AGAINST('\"$term\"' IN BOOLEAN MODE)";
891887
}
892888

893889
switch($serendipity['searchsort']) {

0 commit comments

Comments
 (0)