Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize! not exported + not defined for non-probabilistic case #102

Open
Tracked by #104
THinnerichs opened this issue Feb 17, 2025 · 1 comment
Open
Tracked by #104

Comments

@THinnerichs
Copy link
Member

  1. normalize! is not exported but is crucial when handling probabilities.
  2. When handling non-probabilistic grammars, normalize! should throw an error, e.g. for the following grammar:
grammar = @cfgrammar begin
           Number = |(1:2)
           Number = x
           Number = Number + Number
           Number = Number * Number
       end
@ReubenJ
Copy link
Member

ReubenJ commented Feb 17, 2025

Why should it fail on non-probabilistic grammars? Shouldn't it return the grammar, unchanged?

@THinnerichs THinnerichs mentioned this issue Feb 17, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants