Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix isvariable function #21

Closed
jaapdejong15 opened this issue May 11, 2023 · 1 comment
Closed

Fix isvariable function #21

jaapdejong15 opened this issue May 11, 2023 · 1 comment
Assignees
@ReubenJ
Labels
bug Something isn't working

Comments

@jaapdejong15
Copy link
Member

The isvariable function doesn't take into account that symbols might have a corresponding definition in the Main or Base module or any other module that a user passes to the SymbolTable when evaluating.
Therefore, isvariable should take an optional module and also check whether a symbol is defined in either of these three modules before determining something is a variable.
@jaapdejong15 jaapdejong15 added the bug Something isn't working label May 11, 2023
@ReubenJ ReubenJ self-assigned this Jan 18, 2024
ReubenJ added a commit that referenced this issue Jan 18, 2024
@ReubenJ
Allow for module specification in isvariable(...)
bcfec29 
Allow the specification one or more `Module` when checking if a
rule used by a `RuleNode` represents a variable, or if it is
defined in one of the specified `Module`s, `Main`, or `Base`.

Fixes #21.
@IssaHanou
Copy link
Member

Solved by #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ReubenJ ReubenJ

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ReubenJ @IssaHanou @jaapdejong15 @sourceCode4