Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hasdynamicvalue function calls from rulenode2expr functions #79

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

To5BG
Copy link

@To5BG To5BG commented Jul 5, 2024

Remove hasdynamicvalue function calls from rulenode2expr functions because they cause issues with using _val as an evaluation cache for the Probe algorithm.

…because they cause issues with using `_val` as an evaluation cache for the Probe algorithm.
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.10%. Comparing base (aca61f9) to head (93bec01).

Files Patch % Lines
src/rulenode_operators.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #79   +/-   ##
=======================================
  Coverage   46.10%   46.10%           
=======================================
  Files           8        8           
  Lines         462      462           
=======================================
  Hits          213      213           
  Misses        249      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebdumancic
Copy link
Member

This looks fine to me, the original _val feature is not used anywhere. Shall we merge it without @Whebon's approval, as he is probably recovering after his defence? :)

@Whebon
Copy link
Contributor

Whebon commented Jul 8, 2024

The original _val is not used anymore, making these checks are redundant. It seems like you have a new use-case for the _val field (otherwise the check returns false). Maybe we should add a docstring to RuleNode to clarify what _val is supposed to do and what format it is expected to be in.

@nicolaefilat nicolaefilat merged commit 21cb2e9 into Herb-AI:dev Jul 12, 2024
5 checks passed
@ReubenJ ReubenJ mentioned this pull request Jul 19, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants