HerbGrammar v0.4.0
#83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…because they cause issues with using `_val` as an evaluation cache for the Probe algorithm.
…t-not-expr Bug/csgrammar macro returns object not expr
Remove `hasdynamicvalue` function calls from rulenode2expr functions
…grammars Remove double normalization of probabilistic grammars
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #83 +/- ##
==========================================
- Coverage 46.10% 45.95% -0.16%
==========================================
Files 8 8
Lines 462 457 -5
==========================================
- Hits 213 210 -3
+ Misses 249 247 -2 ☔ View full report in Codecov by Sentry. |
This is necessary to run tests on the respective macros.
Fixes the indexing that relied on line numbers being present
Remove line numbers in PCSG construction
This was referenced Jul 23, 2024
THinnerichs
reviewed
Jul 24, 2024
THinnerichs
reviewed
Jul 24, 2024
THinnerichs
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
RuleNode._val(Bump minor version number HerbCore.jl#25)Breaking Changes
hasdynamicvaluefunction calls from rulenode2expr functions #79Bug Fixes
Performance