You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's places in Cobalt (e.g. BaseProperty.onChange) that would benefit from switching to their lazy logging counterparts, e.g:
logger.debug("Subscribing to changes to property: $this.")
Should be
logger.debug { "Subscribing to changes to property: $this." }
I can't speak for the JVM implementation of uuid, but when looking at performance in the browser for Zircon I could see a fair chunk of time spent in uuid.toString() and garbage collecting strings which went away when using lazy logging and turning debug off.
The text was updated successfully, but these errors were encountered:
MrBergin
changed the title
Use lazy logging for non-constant string
Use lazy logging for non-constant strings
Apr 23, 2020
I just grepped for log\w+\.\w+\( in the whole project and there are only some logger.warn() calls left, so this issue seems to be fixed. Especially the aforementioned call(s) in BaseProperty are already changed.
There's places in Cobalt (e.g.
BaseProperty.onChange
) that would benefit from switching to their lazy logging counterparts, e.g:logger.debug("Subscribing to changes to property: $this.")
Should be
logger.debug { "Subscribing to changes to property: $this." }
I can't speak for the JVM implementation of uuid, but when looking at performance in the browser for Zircon I could see a fair chunk of time spent in
uuid.toString()
and garbage collecting strings which went away when using lazy logging and turning debug off.The text was updated successfully, but these errors were encountered: