Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model structure in code incompatible with in paper #18

Open
HollyDQWang opened this issue Jul 7, 2021 · 5 comments
Open

model structure in code incompatible with in paper #18

HollyDQWang opened this issue Jul 7, 2021 · 5 comments

Comments

@HollyDQWang
Copy link

In paper the network layout was defined as using 3 structure stages and 3 keypoint stages, while in code the 6 stages were divided into 1 structure stage and 5 keypoint stages. What is the reason for such difference in terms of implementation or is it merely a typo?

@HowieMa
Copy link
Owner

HowieMa commented Jul 7, 2021

It should be 3+3, as in the code
image

@HollyDQWang
Copy link
Author

The screenshot displays 1 + 5 if I understand it correctly, as it shows stage1 as using class Stage1 and stage2-stage6 as using class Stage though.

@HowieMa
Copy link
Owner

HowieMa commented Jul 7, 2021

Sorry, but you may misunderstand the code.
Please note that class Stage1 is just two 1x1 Conv layers, which follows OpenPose
You can find that the output channels of stages 1, 2, and 3 are all self.lsh_c, which is the number of limbs.
And the output channels of stages 4, 5, and 6 are "self.outc", which is the number of keypoints.

@HollyDQWang
Copy link
Author

HollyDQWang commented Jul 7, 2021

截屏2021-07-07 下午1 59 25

Please note that class Stage1 is just two 1x1 Conv layers, which follows OpenPose

I think I get what you mean, which is exactly why I was confused: the graph displayed in the paper said to use stage1 (with two 1x1 conv layers) three times for structure stage (limb stage as in your code), but in the code it was used only once. Am I missing something here?

@HowieMa
Copy link
Owner

HowieMa commented Jul 7, 2021

Oops. It seems that our figure is incorrect. Thanks for pointing out this issue.
the "Structure Stage 2" and "Structure Stage 3" should have the same structure as Statge t (t>1), and we should not use the blue background for it.
And the Keypoint Stage 1, 2, and 3 also use the architecture of Stage t (t>1).

Actually, the main idea is that we still follow the architecture of CPM for hand pose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants