fixed two flaky tests in dmestore-service #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed two flaky tests:
com.huawei.dmestore.services.VmfsAccessServiceTest.unmountVmfscom.huawei.dmestore.services.VmfsOperationServiceImplTest.expandVmfsDescription
To reproduce the problem, first build the module
dmestore-service:To identify the flaky tests, execute the following nondex command:
and
The two flaky tests both results from incorrect assumptions about the order of the requestbody implemented by HashMap.
The fix incorporates
LinkedHashMapto replaceHashMapto keep the order consistency.