refactor(frontend): simplify onboarding tour step navigation

- Remove `setTourStep` method in favor of `advanceTourStep`
- Simplify tour step progression across dashboard and media routes
- Update hook return values to use more direct step advancement method

Author: IgnisDa

apps/frontend/app/lib/state/general.tsx

@@ -84,16 +84,11 @@ export const useOnboardingTour = () => {
 		setOpenedSidebarLinks(defaultSidebarLinksState);
 		setTourState({ currentStepIndex: 0 });
 	};
-	const setTourStep = (stepTarget: OnboardingTourStepTargets) => {
-		const index = onboardingTourSteps.findIndex(
-			(step) => step.target === `.${stepTarget}`,
-		);
-		setTourState({ currentStepIndex: index });
+
+	const advanceTourStep = () => {
+		const currentStepIndex = tourState?.currentStepIndex || 0;
+		setTourState({ currentStepIndex: currentStepIndex + 1 });
 	};
-	const incrementStep = () =>
-		setTourState((prev) => ({
-			currentStepIndex: (prev?.currentStepIndex || 0) + 1,
-		}));
 
 	useEffect(() => {
 		const completed = localStorage.getItem(OnboardingTourCompletedKey);
@@ -102,9 +97,8 @@ export const useOnboardingTour = () => {
 	}, []);
 
 	return {
-		setTourStep,
 		isTourStarted,
-		incrementStep,
+		advanceTourStep,
 		stepIndex: tourState?.currentStepIndex,
 	};
 };

apps/frontend/app/routes/_dashboard.media.$action.$lot.tsx

@@ -258,7 +258,7 @@ export default function Page() {
 	] = useDisclosure(false);
 	const navigate = useNavigate();
 	const bulkEditingCollection = useBulkEditCollection();
-	const { isTourStarted, setTourStep } = useOnboardingTour();
+	const { isTourStarted, advanceTourStep } = useOnboardingTour();
 
 	const bulkEditingState = bulkEditingCollection.state;
 	const mediaSearch = loaderData.mediaSearch;
@@ -293,10 +293,7 @@ export default function Page() {
 							),
 						);
 						if (v === "search" && isTourStarted) {
-							setTimeout(
-								() => setTourStep(OnboardingTourStepTargets.Four),
-								400,
-							);
+							setTimeout(() => advanceTourStep(), 400);
 						}
 					}
 				}}
@@ -423,10 +420,7 @@ export default function Page() {
 										? {
 												target: OnboardingTourStepTargets.Four,
 												onTargetInteract: () => {
-													setTimeout(
-														() => setTourStep(OnboardingTourStepTargets.Five),
-														2000,
-													);
+													setTimeout(() => advanceTourStep(), 2000);
 												},
 											}
 										: undefined

apps/frontend/app/routes/_dashboard.tsx

@@ -337,7 +337,7 @@ export default function Layout() {
 		useMeasurementsDrawerOpen();
 	const closeMeasurementsDrawer = () => setMeasurementsDrawerOpen(false);
 	const bulkEditingCollection = useBulkEditCollection();
-	const { isTourStarted, stepIndex, setTourStep } = useOnboardingTour();
+	const { isTourStarted, stepIndex, advanceTourStep } = useOnboardingTour();
 
 	const mediaLinks = [
 		...userPreferences.featuresEnabled.media.specific.map((f) => {
@@ -349,10 +349,7 @@ export default function Layout() {
 						? ({
 								target: OnboardingTourStepTargets.Two,
 								onTargetInteract: () => {
-									setTimeout(
-										() => setTourStep(OnboardingTourStepTargets.Three),
-										1000,
-									);
+									setTimeout(() => advanceTourStep(), 1000);
 								},
 							} as TourControl)
 						: undefined,
@@ -641,8 +638,7 @@ export default function Layout() {
 								opened={openedSidebarLinks.media || false}
 								tourControl={{
 									target: OnboardingTourStepTargets.One,
-									onTargetInteract: () =>
-										setTourStep(OnboardingTourStepTargets.Two),
+									onTargetInteract: () => advanceTourStep(),
 								}}
 								setOpened={(k) =>
 									setOpenedSidebarLinks(