Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cautious-robot logo #24

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Add cautious-robot logo #24

merged 4 commits into from
Aug 30, 2024

Conversation

egrace479
Copy link
Member

Adds AI-generated cautious-robot logo to the README. Set it at 500px so it won't be too large on the screen.

Add cautious-robot logo
@egrace479 egrace479 added the documentation Improvements or additions to documentation label Aug 30, 2024
@egrace479 egrace479 requested a review from thompsonmj August 30, 2024 15:46
Copy link
Contributor

@thompsonmj thompsonmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cute lil guy

@hlapp
Copy link
Member

hlapp commented Aug 30, 2024

Any reason you wouldn't put the logo image into the repo? Also, I would right-float the image. (And you can still put the image at full rez and then resize for display.)

@egrace479
Copy link
Member Author

Any reason you wouldn't put the logo image into the repo? Also, I would right-float the image. (And you can still put the image at full rez and then resize for display.)

When I fixed the height, the aspect ratio doesn't resize under 500px (width will be narrower but height stays fixed). I didn't put it in directly so it'd be visible, but I can adjust both.

Curious, why right float? And do you think 500px is a good fixed size?

generated with Canva Magic Media

Prompt: cautious robot, cute anime style boxy robot head
@hlapp
Copy link
Member

hlapp commented Aug 30, 2024

Curious, why right float? And do you think 500px is a good fixed size?

Without the float, you have this relatively large vertical space that one needs to scroll over without learning anything new. With float, you can have both the logo and the text side-by-side, so the logo artfully embellishes but does not take over the space.

As for the size, 500px is a bit large, and would be especially so on a mobile device. Personally I would instead use relative width (then height will be automatic).

@egrace479
Copy link
Member Author

Curious, why right float? And do you think 500px is a good fixed size?

Without the float, you have this relatively large vertical space that one needs to scroll over without learning anything new. With float, you can have both the logo and the text side-by-side, so the logo artfully embellishes but does not take over the space.

Ahh I misunderstood! Yes, definitely a good idea!

As for the size, 500px is a bit large, and would be especially so on a mobile device. Personally I would instead use relative width (then height will be automatic).

Sounds good.

@egrace479
Copy link
Member Author

Thanks, @hlapp! That was the style fix I needed :)

When you surround a block in HTML tags such as <p/> in Markdown, rendering the markup within that block is disabled.

Also changes the resizing to a set width, which I think will work a little better, but feel free to change it back.
@egrace479 egrace479 merged commit 573e603 into main Aug 30, 2024
8 checks passed
@egrace479 egrace479 deleted the docs/logo branch August 30, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants