-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: tests utils #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one minor comment
{ | ||
"$schema": "https://biomejs.dev/schemas/1.9.4/schema.json", | ||
"formatter": { | ||
"enabled": false | ||
}, | ||
"linter": { | ||
"enabled": false | ||
}, | ||
"organizeImports": { | ||
"enabled": true | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking to add biome here? if so, the settings.json
above should be updated to specify biome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at some point yes but this actually disables the formatter/linter which now my vscode at least finally adheres to lol
🎉 This PR is included in version 3.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Refactors test utils.
Also, removes some quote tokens - moving towards #56