Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: tests utils #107

Merged
merged 17 commits into from
Jan 3, 2025
Merged

refactor: tests utils #107

merged 17 commits into from
Jan 3, 2025

Conversation

janndriessen
Copy link
Collaborator

@janndriessen janndriessen commented Jan 3, 2025

Refactors test utils.

Also, removes some quote tokens - moving towards #56

Copy link
Collaborator

@0xonramp 0xonramp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment

Comment on lines +1 to +12
{
"$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
"formatter": {
"enabled": false
},
"linter": {
"enabled": false
},
"organizeImports": {
"enabled": true
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking to add biome here? if so, the settings.json above should be updated to specify biome

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at some point yes but this actually disables the formatter/linter which now my vscode at least finally adheres to lol

@janndriessen janndriessen merged commit 570f67b into main Jan 3, 2025
2 checks passed
@janndriessen janndriessen deleted the task/refactor-tests-utils branch January 3, 2025 19:00
Copy link

github-actions bot commented Jan 8, 2025

🎉 This PR is included in version 3.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants