feat: update btc base #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janndriessen
commented
Feb 25, 2025
| @@ -45,7 +45,6 @@ jobs: | |||
| # - run: npm run test:btc2xeth | |||
| # - run: npm run test:eth2xbtc | |||
| - run: npm run test:base | |||
| - run: npm run test:icusd | |||
There was a problem hiding this comment.
removing as we don't need to spend time on running deprecated token
janndriessen
commented
Feb 25, 2025
| @@ -23,7 +23,8 @@ const FlashMintLeveragedAerodromeAddress = | |||
| const eth = '0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE' | |||
| const usdcAddress = getTokenByChainAndSymbol(chainId, 'USDC').address | |||
|
|
|||
| describe('LeveragedAerodromeBuilder()', () => { | |||
| // Skip until using again with other new products | |||
| describe.skip('LeveragedAerodromeBuilder()', () => { | |||
There was a problem hiding this comment.
can be skipped for now (unused)
janndriessen
commented
Feb 25, 2025
| @@ -59,7 +59,6 @@ export class FlashMintNavQuoteProvider | |||
| inputToken: isMinting ? inputToken.address : usdc, | |||
| outputToken: isMinting ? usdc : outputToken.address, | |||
| inputAmount: inputTokenAmount.toString(), | |||
| // TODO: | |||
janndriessen
commented
Feb 25, 2025
| } | ||
|
|
||
| export interface FlashMintQuoteRequest { | ||
| // TODO: add taker? |
There was a problem hiding this comment.
will probably do this when we have the new FM contracts for 0x v2 and LIFI. for now it's not necessary yet.
Co-authored-by: 0xonramp <136734776+0xonramp@users.noreply.github.com>
|
🎉 This PR is included in version 3.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates BTC2X and BTC3X on Base to use new
FlashMintLeveragedMorphoAaveLMhttps://basescan.org/address/0xb86E1EEf76Bc835E73B8C80eb786262C33d086D8