Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update issuance modules for dseth and gtceth #47

Merged
merged 5 commits into from
Apr 18, 2024

Conversation

janndriessen
Copy link
Collaborator

@janndriessen janndriessen commented Apr 9, 2024

TODO

  • check that all tests are working when the issuances are updated (tested locally, won't enable all to keep actions fast)
  • check gctETH once available
  • re-enable all tests once it's working.

@janndriessen janndriessen requested a review from 0xonramp April 9, 2024 11:22
@janndriessen janndriessen marked this pull request as draft April 9, 2024 11:24
0xonramp
0xonramp previously approved these changes Apr 9, 2024
# - run: npm run hardhat & npm run test:icreth
# run last - as it alters the block number
- run: npm run hardhat & npm run test:eth2xfli
# - run: npm run hardhat & npm run test:eth2xfli
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXME: re-enable all tests before merging

@janndriessen janndriessen marked this pull request as ready for review April 18, 2024 14:25
@janndriessen janndriessen merged commit d749354 into main Apr 18, 2024
1 check passed
@janndriessen janndriessen deleted the task/update-issuance-modules branch April 18, 2024 14:25
@janndriessen
Copy link
Collaborator Author

gtcETH will be updated once the change is approved/signed by gitcoin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants