Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: aEthWeth and aEthWBTC #41

Merged
merged 4 commits into from
Mar 15, 2024
Merged

feat: aEthWeth and aEthWBTC #41

merged 4 commits into from
Mar 15, 2024

Conversation

0xonramp
Copy link
Collaborator

@0xonramp 0xonramp commented Mar 15, 2024

Adds support for new Aave tokens and adds publish support.

@0xonramp 0xonramp changed the title feat: aEthWeth feat: aEthWeth and aEthWBTC Mar 15, 2024
@0xonramp 0xonramp requested a review from janndriessen March 15, 2024 04:32
@0xonramp 0xonramp marked this pull request as ready for review March 15, 2024 04:33
# NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
# GH_TOKEN: ${{ secrets.GH_TOKEN }}
# run: npx semantic-release --branches main
publish:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

symbol: 'aEthWBTC',
decimals: 8,
logoURI:
'https://assets.coingecko.com/coins/images/14244/thumb/aWBTC.41453c2a.png?1615528721',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should use large instead of thumb for images.

symbol: 'aEthWETH',
decimals: 18,
logoURI:
'https://assets.coingecko.com/coins/images/17238/thumb/aWETH_2x.png?1626940782',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should use large instead of thumb for images.

@0xonramp 0xonramp merged commit 2708e43 into main Mar 15, 2024
2 checks passed
@0xonramp 0xonramp deleted the feat/aethweth branch March 15, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants