From 836e7897a21ce7c5d7fcd8ab6ce6c5ff47e64f36 Mon Sep 17 00:00:00 2001
From: Arne Dumarey <dumarey.arne@gmail.com>
Date: Wed, 27 Mar 2024 11:08:16 +0100
Subject: [PATCH] fix: mainbuildingtype realizeunplannedbuildingunit

---
 ...ndMeasureUnplannedBuildingLambdaHandler.cs |  2 +-
 ...nRealizingAndMeasuringUnplannedBuilding.cs | 12 ++++--
 ...ngUnplannedBuilding_BuildingUnitAddress.cs | 39 ++++++++++++-------
 3 files changed, 34 insertions(+), 19 deletions(-)

diff --git a/src/BuildingRegistry.Api.BackOffice.Handlers.Lambda/Handlers/Building/RealizeAndMeasureUnplannedBuildingLambdaHandler.cs b/src/BuildingRegistry.Api.BackOffice.Handlers.Lambda/Handlers/Building/RealizeAndMeasureUnplannedBuildingLambdaHandler.cs
index 5a935b0f7..4483f9b6d 100644
--- a/src/BuildingRegistry.Api.BackOffice.Handlers.Lambda/Handlers/Building/RealizeAndMeasureUnplannedBuildingLambdaHandler.cs
+++ b/src/BuildingRegistry.Api.BackOffice.Handlers.Lambda/Handlers/Building/RealizeAndMeasureUnplannedBuildingLambdaHandler.cs
@@ -20,7 +20,7 @@ namespace BuildingRegistry.Api.BackOffice.Handlers.Lambda.Handlers.Building
 
     public sealed class RealizeAndMeasureUnplannedBuildingLambdaHandler : BuildingLambdaHandler<RealizeAndMeasureUnplannedBuildingLambdaRequest>
     {
-        private const string MainBuildingGrbObjectType = "1";
+        private const string MainBuildingGrbObjectType = "MainBuilding";
 
         private readonly IParcelMatching _parcelMatching;
         private readonly IAddresses _addresses;
diff --git a/test/BuildingRegistry.Tests/BackOffice/Lambda/Building/WhenRealizingAndMeasuringUnplannedBuilding.cs b/test/BuildingRegistry.Tests/BackOffice/Lambda/Building/WhenRealizingAndMeasuringUnplannedBuilding.cs
index a7c5a3980..743d8fc4f 100644
--- a/test/BuildingRegistry.Tests/BackOffice/Lambda/Building/WhenRealizingAndMeasuringUnplannedBuilding.cs
+++ b/test/BuildingRegistry.Tests/BackOffice/Lambda/Building/WhenRealizingAndMeasuringUnplannedBuilding.cs
@@ -23,6 +23,7 @@ namespace BuildingRegistry.Tests.BackOffice.Lambda.Building
     using Fixtures;
     using FluentAssertions;
     using Microsoft.Extensions.Configuration;
+    using Microsoft.Extensions.Logging.Abstractions;
     using Moq;
     using NodaTime;
     using SqlStreamStore;
@@ -33,6 +34,8 @@ namespace BuildingRegistry.Tests.BackOffice.Lambda.Building
 
     public partial class WhenRealizingAndMeasuringUnplannedBuilding : BackOfficeLambdaTest
     {
+        private const string MainBuildingObjectType = "MainBuilding";
+
         private readonly IdempotencyContext _idempotencyContext;
         private readonly BackOfficeContext _backOfficeContext;
         private readonly Mock<IPersistentLocalIdGenerator> _persistentLocalIdGenerator;
@@ -63,7 +66,8 @@ public async Task ThenBuildingIsRealizedAndMeasured()
                 Mock.Of<IAddresses>(),
                 _backOfficeContext,
                 _persistentLocalIdGenerator.Object,
-                Container);
+                Container,
+                NullLoggerFactory.Instance);
 
             //Act
             await handler.Handle(
@@ -119,7 +123,8 @@ public async Task WhenIdempotencyException_ThenTicketingCompleteIsExpected()
                 Mock.Of<IAddresses>(),
                 _backOfficeContext,
                 _persistentLocalIdGenerator.Object,
-                Container);
+                Container,
+                NullLoggerFactory.Instance);
 
             //Act
             await handler.Handle(
@@ -172,7 +177,8 @@ public async Task GivenRetryingRequest_ThenBuildingIsRealizedAndMeasured()
                 Mock.Of<IAddresses>(),
                 _backOfficeContext,
                 _persistentLocalIdGenerator.Object,
-                Container);
+                Container,
+                NullLoggerFactory.Instance);
 
             var request = new RealizeAndMeasureUnplannedBuildingLambdaRequest(
                 buildingPersistentLocalId,
diff --git a/test/BuildingRegistry.Tests/BackOffice/Lambda/Building/WhenRealizingAndMeasuringUnplannedBuilding_BuildingUnitAddress.cs b/test/BuildingRegistry.Tests/BackOffice/Lambda/Building/WhenRealizingAndMeasuringUnplannedBuilding_BuildingUnitAddress.cs
index 35c94c7bc..39e4ae7eb 100644
--- a/test/BuildingRegistry.Tests/BackOffice/Lambda/Building/WhenRealizingAndMeasuringUnplannedBuilding_BuildingUnitAddress.cs
+++ b/test/BuildingRegistry.Tests/BackOffice/Lambda/Building/WhenRealizingAndMeasuringUnplannedBuilding_BuildingUnitAddress.cs
@@ -22,6 +22,7 @@ namespace BuildingRegistry.Tests.BackOffice.Lambda.Building
     using BuildingRegistry.Building.Events;
     using FluentAssertions;
     using Microsoft.Extensions.Configuration;
+    using Microsoft.Extensions.Logging.Abstractions;
     using Moq;
     using NetTopologySuite.Geometries;
     using NodaTime;
@@ -77,7 +78,8 @@ public async Task MainBuildingWithRemovedAddress_ThenNotRealizeUnplannedBuilding
                 addresses.Object,
                 _backOfficeContext,
                 _persistentLocalIdGenerator.Object,
-                Container);
+                Container,
+                NullLoggerFactory.Instance);
 
             //Act
             var buildingPersistentLocalId = Fixture.Create<BuildingPersistentLocalId>();
@@ -95,7 +97,7 @@ await handler.Handle(
                         {
                             GrbData = new GrbData
                             {
-                                GrbObjectType = "1",
+                                GrbObjectType = MainBuildingObjectType,
                                 VersionDate = SystemClock.Instance.GetCurrentInstant().ToString(),
                                 GeometriePolygoon =
                                     "<gml:Polygon srsName=\"https://www.opengis.net/def/crs/EPSG/0/31370\" xmlns:gml=\"http://www.opengis.net/gml/3.2\"><gml:exterior><gml:LinearRing><gml:posList>140284.15277253836 186724.74131567031 140291.06016454101 186726.38355567306 140288.22675654292 186738.25798767805 140281.19098053873 186736.57913967967 140284.15277253836 186724.74131567031</gml:posList></gml:LinearRing></gml:exterior></gml:Polygon>",
@@ -159,7 +161,8 @@ public async Task MainBuildingWithNotActiveAddresses_ThenNotRealizeUnplannedBuil
                 addresses.Object,
                 _backOfficeContext,
                 _persistentLocalIdGenerator.Object,
-                Container);
+                Container,
+                NullLoggerFactory.Instance);
 
             //Act
             var buildingPersistentLocalId = Fixture.Create<BuildingPersistentLocalId>();
@@ -177,7 +180,7 @@ await handler.Handle(
                         {
                             GrbData = new GrbData
                             {
-                                GrbObjectType = "1",
+                                GrbObjectType = MainBuildingObjectType,
                                 VersionDate = SystemClock.Instance.GetCurrentInstant().ToString(),
                                 GeometriePolygoon =
                                     "<gml:Polygon srsName=\"https://www.opengis.net/def/crs/EPSG/0/31370\" xmlns:gml=\"http://www.opengis.net/gml/3.2\"><gml:exterior><gml:LinearRing><gml:posList>140284.15277253836 186724.74131567031 140291.06016454101 186726.38355567306 140288.22675654292 186738.25798767805 140281.19098053873 186736.57913967967 140284.15277253836 186724.74131567031</gml:posList></gml:LinearRing></gml:exterior></gml:Polygon>",
@@ -246,7 +249,8 @@ await _backOfficeContext.AddIdempotentBuildingUnitAddressRelation(
                 addresses.Object,
                 _backOfficeContext,
                 _persistentLocalIdGenerator.Object,
-                Container);
+                Container,
+                NullLoggerFactory.Instance);
 
             //Act
             var buildingPersistentLocalId = Fixture.Create<BuildingPersistentLocalId>();
@@ -264,7 +268,7 @@ await handler.Handle(
                         {
                             GrbData = new GrbData
                             {
-                                GrbObjectType = "1",
+                                GrbObjectType = MainBuildingObjectType,
                                 VersionDate = SystemClock.Instance.GetCurrentInstant().ToString(),
                                 GeometriePolygoon =
                                     "<gml:Polygon srsName=\"https://www.opengis.net/def/crs/EPSG/0/31370\" xmlns:gml=\"http://www.opengis.net/gml/3.2\"><gml:exterior><gml:LinearRing><gml:posList>140284.15277253836 186724.74131567031 140291.06016454101 186726.38355567306 140288.22675654292 186738.25798767805 140281.19098053873 186736.57913967967 140284.15277253836 186724.74131567031</gml:posList></gml:LinearRing></gml:exterior></gml:Polygon>",
@@ -337,7 +341,8 @@ public async Task MainBuildingWithTwoUnderlyingParcelAddress_ThenNotRealizeUnpla
                 addresses.Object,
                 _backOfficeContext,
                 _persistentLocalIdGenerator.Object,
-                Container);
+                Container,
+                NullLoggerFactory.Instance);
 
             //Act
             var buildingPersistentLocalId = Fixture.Create<BuildingPersistentLocalId>();
@@ -355,7 +360,7 @@ await handler.Handle(
                         {
                             GrbData = new GrbData
                             {
-                                GrbObjectType = "1",
+                                GrbObjectType = MainBuildingObjectType,
                                 VersionDate = SystemClock.Instance.GetCurrentInstant().ToString(),
                                 GeometriePolygoon =
                                     "<gml:Polygon srsName=\"https://www.opengis.net/def/crs/EPSG/0/31370\" xmlns:gml=\"http://www.opengis.net/gml/3.2\"><gml:exterior><gml:LinearRing><gml:posList>140284.15277253836 186724.74131567031 140291.06016454101 186726.38355567306 140288.22675654292 186738.25798767805 140281.19098053873 186736.57913967967 140284.15277253836 186724.74131567031</gml:posList></gml:LinearRing></gml:exterior></gml:Polygon>",
@@ -417,7 +422,8 @@ public async Task MainBuildingWithNoUnderlyingParcelAddress_ThenNotRealizeUnplan
                 addresses.Object,
                 _backOfficeContext,
                 _persistentLocalIdGenerator.Object,
-                Container);
+                Container,
+                NullLoggerFactory.Instance);
 
             //Act
             var buildingPersistentLocalId = Fixture.Create<BuildingPersistentLocalId>();
@@ -435,7 +441,7 @@ await handler.Handle(
                         {
                             GrbData = new GrbData
                             {
-                                GrbObjectType = "1",
+                                GrbObjectType = MainBuildingObjectType,
                                 VersionDate = SystemClock.Instance.GetCurrentInstant().ToString(),
                                 GeometriePolygoon =
                                     "<gml:Polygon srsName=\"https://www.opengis.net/def/crs/EPSG/0/31370\" xmlns:gml=\"http://www.opengis.net/gml/3.2\"><gml:exterior><gml:LinearRing><gml:posList>140284.15277253836 186724.74131567031 140291.06016454101 186726.38355567306 140288.22675654292 186738.25798767805 140281.19098053873 186736.57913967967 140284.15277253836 186724.74131567031</gml:posList></gml:LinearRing></gml:exterior></gml:Polygon>",
@@ -496,7 +502,8 @@ public async Task MainBuildingWithOneUnderlyingParcelAddress_ThenRealizeUnplanne
                 addresses.Object,
                 _backOfficeContext,
                 _persistentLocalIdGenerator.Object,
-                Container);
+                Container,
+                NullLoggerFactory.Instance);
 
             //Act
             var buildingPersistentLocalId = Fixture.Create<BuildingPersistentLocalId>();
@@ -514,7 +521,7 @@ await handler.Handle(
                         {
                             GrbData = new GrbData
                             {
-                                GrbObjectType = "1",
+                                GrbObjectType = MainBuildingObjectType,
                                 VersionDate = SystemClock.Instance.GetCurrentInstant().ToString(),
                                 GeometriePolygoon =
                                     "<gml:Polygon srsName=\"https://www.opengis.net/def/crs/EPSG/0/31370\" xmlns:gml=\"http://www.opengis.net/gml/3.2\"><gml:exterior><gml:LinearRing><gml:posList>140284.15277253836 186724.74131567031 140291.06016454101 186726.38355567306 140288.22675654292 186738.25798767805 140281.19098053873 186736.57913967967 140284.15277253836 186724.74131567031</gml:posList></gml:LinearRing></gml:exterior></gml:Polygon>",
@@ -573,7 +580,8 @@ public async Task ThenRealizeUnplannedBuildingUnitIsIdempotent()
                 addresses.Object,
                 _backOfficeContext,
                 _persistentLocalIdGenerator.Object,
-                Container);
+                Container,
+                NullLoggerFactory.Instance);
 
             //Act
             var buildingPersistentLocalId = Fixture.Create<BuildingPersistentLocalId>();
@@ -592,7 +600,7 @@ public async Task ThenRealizeUnplannedBuildingUnitIsIdempotent()
                     {
                         GrbData = new GrbData
                         {
-                            GrbObjectType = "1",
+                            GrbObjectType = MainBuildingObjectType,
                             VersionDate = SystemClock.Instance.GetCurrentInstant().ToString(),
                             GeometriePolygoon =
                                 "<gml:Polygon srsName=\"https://www.opengis.net/def/crs/EPSG/0/31370\" xmlns:gml=\"http://www.opengis.net/gml/3.2\"><gml:exterior><gml:LinearRing><gml:posList>140284.15277253836 186724.74131567031 140291.06016454101 186726.38355567306 140288.22675654292 186738.25798767805 140281.19098053873 186736.57913967967 140284.15277253836 186724.74131567031</gml:posList></gml:LinearRing></gml:exterior></gml:Polygon>",
@@ -654,7 +662,8 @@ public async Task NotMainBuilding_ThenNoRealizeUnplannedBuildingUnitCommand(stri
                 Mock.Of<IAddresses>(),
                 _backOfficeContext,
                 _persistentLocalIdGenerator.Object,
-                Container);
+                Container,
+                NullLoggerFactory.Instance);
 
             //Act
             var buildingPersistentLocalId = Fixture.Create<BuildingPersistentLocalId>();