From a72db625a8076704a23192084ebab9c8ff1c8b6f Mon Sep 17 00:00:00 2001 From: jvandaal Date: Fri, 24 May 2024 12:44:19 +0200 Subject: [PATCH] refactor: clean up dead code --- .../Building/BuildingController.cs | 14 +++++--------- .../Building/BuildingOsloController.cs | 9 --------- .../BuildingUnit/BuildingUnitOsloController.cs | 10 ++-------- 3 files changed, 7 insertions(+), 26 deletions(-) diff --git a/src/BuildingRegistry.Api.Legacy/Building/BuildingController.cs b/src/BuildingRegistry.Api.Legacy/Building/BuildingController.cs index 4041f68c5..32b316dba 100755 --- a/src/BuildingRegistry.Api.Legacy/Building/BuildingController.cs +++ b/src/BuildingRegistry.Api.Legacy/Building/BuildingController.cs @@ -29,7 +29,6 @@ namespace BuildingRegistry.Api.Legacy.Building using Microsoft.Extensions.Options; using Microsoft.SyndicationFeed; using Microsoft.SyndicationFeed.Atom; - using Projections.Legacy; using Query; using Swashbuckle.AspNetCore.Filters; using Sync; @@ -82,8 +81,6 @@ await _mediator.Send( /// /// Vraag een lijst met actieve gebouwn op. /// - /// - /// /// /// Als de opvraging van een lijst met gebouwn gelukt is. /// Als er een interne fout is opgetreden. @@ -94,8 +91,6 @@ await _mediator.Send( [SwaggerResponseExample(StatusCodes.Status200OK, typeof(BuildingListResponseExamples))] [SwaggerResponseExample(StatusCodes.Status500InternalServerError, typeof(InternalServerErrorResponseExamples))] public async Task List( - [FromServices] LegacyContext context, - [FromServices] IOptions responseOptions, CancellationToken cancellationToken = default) { var listResponse = await _mediator.Send( @@ -122,7 +117,8 @@ public async Task List( [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status500InternalServerError)] [SwaggerResponseExample(StatusCodes.Status200OK, typeof(TotalCountResponseExample))] [SwaggerResponseExample(StatusCodes.Status500InternalServerError, typeof(InternalServerErrorResponseExamples))] - public async Task Count(CancellationToken cancellationToken = default) + public async Task Count( + CancellationToken cancellationToken = default) { var response = await _mediator.Send(new CountRequest( Request.ExtractFilteringRequest(), @@ -191,7 +187,7 @@ private static async Task BuildAtomFeed( : (long?) null; var nextUri = BuildNextSyncUri(pagedBuildings.PaginationInfo.Limit, nextFrom, - syndicationConfiguration["NextUri"]); + syndicationConfiguration["NextUri"]!); if (nextUri is not null) { await writer.Write(new SyndicationLink(nextUri, "next")); @@ -202,8 +198,8 @@ private static async Task BuildAtomFeed( await writer.WriteBuilding( responseOptions, formatter, - syndicationConfiguration["Category1"], - syndicationConfiguration["Category2"], + syndicationConfiguration["Category1"]!, + syndicationConfiguration["Category2"]!, building); } diff --git a/src/BuildingRegistry.Api.Oslo/Building/BuildingOsloController.cs b/src/BuildingRegistry.Api.Oslo/Building/BuildingOsloController.cs index f7e5ea615..f8672e4a6 100644 --- a/src/BuildingRegistry.Api.Oslo/Building/BuildingOsloController.cs +++ b/src/BuildingRegistry.Api.Oslo/Building/BuildingOsloController.cs @@ -13,13 +13,10 @@ namespace BuildingRegistry.Api.Oslo.Building using Count; using Detail; using Infrastructure; - using Infrastructure.Options; using List; using MediatR; using Microsoft.AspNetCore.Http; using Microsoft.AspNetCore.Mvc; - using Microsoft.Extensions.Options; - using Projections.Legacy; using Query; using Swashbuckle.AspNetCore.Filters; using ProblemDetails = Be.Vlaanderen.Basisregisters.BasicApiProblem.ProblemDetails; @@ -72,8 +69,6 @@ await _mediator.Send( /// /// Vraag een lijst met actieve gebouwn op. /// - /// - /// /// /// Als de opvraging van een lijst met gebouwn gelukt is. /// Als er een interne fout is opgetreden. @@ -85,8 +80,6 @@ await _mediator.Send( [SwaggerResponseExample(StatusCodes.Status200OK, typeof(BuildingListResponseOsloExamples))] [SwaggerResponseExample(StatusCodes.Status500InternalServerError, typeof(InternalServerErrorResponseExamples))] public async Task List( - [FromServices] LegacyContext context, - [FromServices] IOptions responseOptions, CancellationToken cancellationToken = default) { var listResponse = await _mediator.Send( @@ -105,7 +98,6 @@ public async Task List( /// /// Vraag het totaal aantal actieve gebouwen op. /// - /// /// /// Als de opvraging van het totaal aantal gelukt is. /// Als er een interne fout is opgetreden. @@ -116,7 +108,6 @@ public async Task List( [SwaggerResponseExample(StatusCodes.Status200OK, typeof(TotalCountOsloResponseExample))] [SwaggerResponseExample(StatusCodes.Status500InternalServerError, typeof(InternalServerErrorResponseExamples))] public async Task Count( - [FromServices] LegacyContext context, CancellationToken cancellationToken = default) { var response = await _mediator.Send(new BuildingCountRequest( diff --git a/src/BuildingRegistry.Api.Oslo/BuildingUnit/BuildingUnitOsloController.cs b/src/BuildingRegistry.Api.Oslo/BuildingUnit/BuildingUnitOsloController.cs index 3d611aa96..c572898a0 100644 --- a/src/BuildingRegistry.Api.Oslo/BuildingUnit/BuildingUnitOsloController.cs +++ b/src/BuildingRegistry.Api.Oslo/BuildingUnit/BuildingUnitOsloController.cs @@ -13,13 +13,10 @@ namespace BuildingRegistry.Api.Oslo.BuildingUnit using Count; using Detail; using Infrastructure; - using Infrastructure.Options; using List; using MediatR; using Microsoft.AspNetCore.Http; using Microsoft.AspNetCore.Mvc; - using Microsoft.Extensions.Options; - using Projections.Legacy; using Query; using Swashbuckle.AspNetCore.Filters; @@ -39,8 +36,6 @@ public BuildingUnitOsloController(IMediator mediator) /// /// Vraag een lijst met actieve gebouweenheden op. /// - /// - /// /// /// Als de opvraging van een lijst met gebouweenheden gelukt is. /// Als er een interne fout is opgetreden. @@ -52,8 +47,6 @@ public BuildingUnitOsloController(IMediator mediator) [SwaggerResponseExample(StatusCodes.Status200OK, typeof(BuildingUnitListOsloResponseExamples))] [SwaggerResponseExample(StatusCodes.Status500InternalServerError, typeof(InternalServerErrorResponseExamples))] public async Task List( - [FromServices] LegacyContext context, - [FromServices] IOptions responseOptions, CancellationToken cancellationToken = default) { var filtering = Request.ExtractFilteringRequest(); @@ -80,7 +73,8 @@ public async Task List( [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status500InternalServerError)] [SwaggerResponseExample(StatusCodes.Status200OK, typeof(TotalCountOsloResponseExample))] [SwaggerResponseExample(StatusCodes.Status500InternalServerError, typeof(InternalServerErrorResponseExamples))] - public async Task Count(CancellationToken cancellationToken = default) + public async Task Count( + CancellationToken cancellationToken = default) { var filtering = Request.ExtractFilteringRequest(); var sorting = Request.ExtractSortingRequest();