Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Cleanup #1

Open
siddharth-joshi opened this issue Jan 16, 2024 · 0 comments
Open

Initial Cleanup #1

siddharth-joshi opened this issue Jan 16, 2024 · 0 comments

Comments

@siddharth-joshi
Copy link

Please do as follows

  • Please use requirements.txt for dependency and versioning management
  • Update your gitignore to not track files like .DS_Store and build artifacts (e.g., .egg files/contents/folders)
  • Remove dead code (e.g., custom_learning.py has dead code for RTRL)
  • Run things through a linter, feel free to use the same settings as Flax (Pylint https://github.com/google/flax/blob/main/pylintrc )
  • Please set up a set of unit tests for modules (it will make extending your code easier)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@siddharth-joshi