Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BibLaTeX seasons cause exception on import and export #12437

Closed
2 tasks done
distressingly opened this issue Jan 31, 2025 · 11 comments · Fixed by #12537
Closed
2 tasks done

BibLaTeX seasons cause exception on import and export #12437

distressingly opened this issue Jan 31, 2025 · 11 comments · Fixed by #12537
Assignees
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) component: import-load

Comments

@distressingly
Copy link

distressingly commented Jan 31, 2025

JabRef version

Latest development branch build (please note build date below)

Operating system

Windows

Details on version and operating system

Windows 11 24H2 / JabRef 6.0-alpha.65

Checked with the latest development build (copy version output from About dialog)

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Import an entry with date = {1991-21}

Appendix

BibLaTeX allows seasons following ISO 8601, which are encoded by using 21–24 in the month field.

java.time.DateTimeException: Invalid value for MonthOfYear (valid values 1 - 12): 21

@urlyy
Copy link
Contributor

urlyy commented Feb 17, 2025

@koppor I noticed that your handling of date(format and parse) in biblatex seems to be implemented without relying on third-party libraries, which might lead to some oversights in these standards.

Image

Image

Since accessing ISO 8601 requires payment, I referred to these four documents :

So I confirmed that biblatex does indeed have specific support for seasons. However, in jabref code, the second part of date is recognized as the month. And because it does not conform to the range of months, an exception is thrown.

Image

Image

I am going to participate in this year's GSoC and am looking for a small issue to familiarize myself with JabRef. But first, I'd like to ask whether you think this issue needs to be addressed.

@koppor
Copy link
Member

koppor commented Feb 18, 2025

I am going to participate in this year's GSoC and am looking for a small issue to familiarize myself with JabRef. But first, I'd like to ask whether you think this issue needs to be addressed.

Yes, please do so. The issue was risen by a GitHub user seeming non-fake and your screenshot shows that is a valid value.

@Siedlerchr
Copy link
Member

Still wtf for me, who to the hell comes up with such ideas in a Standard to abuse the month field o.O

@urlyy
Copy link
Contributor

urlyy commented Feb 18, 2025

/assign-me

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Feb 18, 2025
Copy link
Contributor

👋 Hey @urlyy, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if the issue isn't closed within 90 days (by 19 May 2025). A maintainer can also add the "📌 Pinned"" label to prevent automatic unassignment.

@distressingly
Copy link
Author

@koppor I noticed that your handling of date(format and parse) in biblatex seems to be implemented without relying on third-party libraries, which might lead to some oversights in these standards.

Image

Image

Since accessing ISO 8601 requires payment, I referred to these four documents :

So I confirmed that biblatex does indeed have specific support for seasons. However, in jabref code, the second part of date is recognized as the month. And because it does not conform to the range of months, an exception is thrown.

Image

Image

I am going to participate in this year's GSoC and am looking for a small issue to familiarize myself with JabRef. But first, I'd like to ask whether you think this issue needs to be addressed.

The alias in the BibLaTeX documentation is yeardivision, for the record.

@Siedlerchr
Copy link
Member

@distressingly Thanks to @urlyy this issue is now fixed in the the latest developement branch

@koppor
Copy link
Member

koppor commented Mar 3, 2025

@urlyy Thank you for working on this issue and fixing it fast with high quality! We invite you to choose some other issue. Maybe some "small" from https://github.com/orgs/JabRef/projects/3/views/3? Maybe #12467?

@urlyy
Copy link
Contributor

urlyy commented Mar 4, 2025

@koppor Thank you for the invitation!🥹 However, I've been quite busy these days. If I can find some free time in the future, I might come back to work on some issues, and possibly contribute to gsoc as well.

@subhramit
Copy link
Member

@koppor Thank you for the invitation!🥹 However, I've been quite busy these days. If I can find some free time in the future, I might come back to work on some issues, and possibly contribute to gsoc as well.

Looking forward to seeing you :)

@koppor
Copy link
Member

koppor commented Mar 4, 2025

@koppor Thank you for the invitation!🥹 However, I've been quite busy these days. If I can find some free time in the future, I might come back to work on some issues, and possibly contribute to gsoc as well.

Please ping me on Gitter regarding GSoC so that we can discuss which project might work well for you. Maybe https://github.com/JabRef/jabref/wiki/GSoC-2025-ideas-list#using-postgresql-as-full-backend-for-jabref is an adequate challenge for you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) component: import-load
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants