Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks with some affiliate links ( https://smile.amazon.com/?sa-no-redirect=1 ) #51

Open
SamuelWN opened this issue Feb 28, 2021 · 1 comment

Comments

@SamuelWN
Copy link

SamuelWN commented Feb 28, 2021

When attempting to follow links from the The WireCutter, the extension causes the page to redirect to https://smile.amazon.com/?sa-no-redirect=1 .

I initially thought it might have something to do with the redirect chain that Wirecutter uses. However, parsing through the DevTools network log revealed it to be an issue with the final Amazon URL instead.

Example:
Loading up a new window and attempting to navigate to:
https://www.amazon.com/dp/B0845NXCXF/?tag=thewire06-20&linkCode=xm2&ascsubtag=AwEAAAAAAAAAAepL

will cause the user to be redirected to https://smile.amazon.com/?sa-no-redirect=1. This does not occur when the smilealways extension is disabled.

@SamuelWN
Copy link
Author

Failed to check that the issue occurs even while adjusting the URL manually, and it does.
i.e.
https://smile.amazon.com/dp/B0845NXCXF/?tag=thewire06-20&linkCode=xm2&ascsubtag=AwEAAAAAAAAAAepL
redirects to:
https://smile.amazon.com/

Trial & error points to the problematic parameter being the affiliate ID (tag=thewire06-20). If the extension could be tweaked handle such instances, that'd be great.

Giving the user the option to select whether it handles it by removing the affiliate ID or simply not forward to smile.amazon would be the optimal solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant