Skip to content

Commit 08a014e

Browse files
committed
Match variable names to docs
Update variable name style (and comments) to match docs
1 parent a9442fa commit 08a014e

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

src/machines.jl

+10-10
Original file line numberDiff line numberDiff line change
@@ -580,10 +580,10 @@ or none of the following apply:
580580
changed since the last time `mach` was trained (ie, the last time
581581
`mach.state` was last incremented).
582582
583-
4. The specified `rows` have changed since the last retraining and
583+
4. The specified `rows` have changed since the last retraining and
584584
`mach.model` does not have `Static` type.
585585
586-
5. `mach.model` is a model and different from the last model used for training, but has
586+
5. `mach.model` is a model and different from the last model used for training, but has
587587
the same type.
588588
589589
6. `mach.model` is a model but has a type different from the last model used for
@@ -658,7 +658,7 @@ function fit_only!(
658658
rows === nothing && (rows = (:))
659659
rows_is_new = !isdefined(mach, :old_rows) || rows != mach.old_rows
660660

661-
condition_iv = rows_is_new && !(mach.model isa Static)
661+
condition_4 = rows_is_new && !(mach.model isa Static)
662662

663663
upstream_has_changed = mach.old_upstream_state != upstream_state
664664

@@ -672,16 +672,16 @@ function fit_only!(
672672

673673
# build or update cached `resampled_data` if necessary (`mach.data` is already defined
674674
# above if needed here):
675-
if cache_data && (!data_is_valid || condition_iv)
675+
if cache_data && (!data_is_valid || condition_4)
676676
mach.resampled_data = selectrows(model, rows, mach.data...)
677677
end
678678

679679
# `fit`, `update`, or return untouched:
680-
if mach.state == 0 || # condition (i)
681-
force == true || # condition (ii)
682-
upstream_has_changed || # condition (iii)
683-
condition_iv || # condition (iv)
684-
modeltype_changed # conditions (vi) or (vii)
680+
if mach.state == 0 || # condition (1)
681+
force == true || # condition (2)
682+
upstream_has_changed || # condition (3)
683+
condition_4 || # condition (4)
684+
modeltype_changed # conditions (6) or (7)
685685

686686
isdefined(mach, :report) || (mach.report = LittleDict{Symbol,Any}())
687687

@@ -709,7 +709,7 @@ function fit_only!(
709709
rethrow()
710710
end
711711

712-
elseif model != mach.old_model # condition (v)
712+
elseif model != mach.old_model # condition (5)
713713

714714
# update the model:
715715
fitlog(mach, :update, verbosity)

0 commit comments

Comments
 (0)