Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify interface for find_roots #34

Open
dpsanders opened this issue May 19, 2015 · 2 comments
Open

Simplify interface for find_roots #34

dpsanders opened this issue May 19, 2015 · 2 comments
Labels
root-finding

Comments

@dpsanders
Copy link
Member

Currently, find_roots is just a thin interface wrapping newton, and returns a slightly complicated structure, namely an array of Root objects, which are tuples of the Interval containing the root and a symbol saying if the root is :unique or :unknown.

I would like find_roots (or a similar simple name) to be an interface for someone who wants to use ValidatedNumerics as a black box, so that they should not need to know anything about intervals.

Currently, in the midpoint_radius branch, there is find_roots_midpoint that returns three arrays: the midpoints, the radii, and the symbols. This can be used with no knowledge of Interval.

My proposal is to rename find_roots_radius to find_roots and assume that a user familiar with interval arithmetic will be happy using the interface directly via newton or krawczyk and dealing with the resulting intervals.

cc @lbenet
dpsanders referenced this issue May 22, 2015
@dpsanders
Add midpoint-radius representation and Horner method.
9471568 
Added inverse trig functions

Added tests for inverse trig functions

Added floor and ceil for intervals

Added tests for asin and acos when interval is not in domain. Added inverse trig functions in automatic_differentiation (need tests)

Remove Float from newton tests due to Travis

Added midpoint_radius

Removed clean_roots and its necessity; added find_roots_midpoint

Added with_interval_precision

Restore sort! for roots in newton and krawczyk

Generate Wilkinson polynomials using Horner's method

Minor changes

Added possibility to have array references of form a[i] inside @interval

Rewrite symbol generation for W3 since previous version only worked on Julia v0.4
@lbenet
Copy link
Member

lbenet commented May 24, 2015

What about simply including some conversion functions? That is, find_roots returns an array of Roots, and through some functions (e.g., interval_to_midpoint) does the rest of the work. The name is a simple suggestion, not more than that...

@lbenet
Copy link
Member

lbenet commented May 24, 2015

My previous comment is related to the ideas behind #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
root-finding
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dpsanders @lbenet