Frank eitt fix #771
Merged
Frank eitt fix #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WAvdBeek
requested changes
Feb 27, 2024
api/oc_knx_sec.c
Outdated
| @@ -670,6 +670,11 @@ oc_core_auth_at_post_handler(oc_request_t *request, | |||
| char *if_str = oc_string_array_get_item(str_array, i); | |||
| oc_interface_mask_t if_mask = | |||
| oc_ri_get_interface_mask(if_str, strlen(if_str)); | |||
| if (if_mask == OC_IF_LI) { | |||
| PRINT(" if.ll is not a valid access scope!\n"); | |||
There was a problem hiding this comment.
can we do this as a debug statement (OC_DEBUG)?
There was a problem hiding this comment.
Fixed. I used OC_ERR since it's an error that's leading to a BAD_REQUEST response
| @@ -775,7 +774,7 @@ oc_do_s_mode_with_scope_and_check(int scope, const char *resource_url, char *rp, | |||
| PRINT(" handling: index %d\n", index); | |||
| for (int j = 0; j < ga_len; j++) { | |||
| group_address = oc_core_find_group_object_table_group_entry(index, j); | |||
| PRINT(" ga : %d\n", group_address); | |||
| PRINT(" ga : %lu\n", group_address); | |||
There was a problem hiding this comment.
This was a PRINT before, I just fixed the format identifier. There's quite a few more PRINT's in this function, do you want me to change them all?
|
~format |
|
~format |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.