Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster training time cheese #2499

Open
ezsnackeur opened this issue Feb 5, 2025 · 9 comments
Open

Faster training time cheese #2499

ezsnackeur opened this issue Feb 5, 2025 · 9 comments

Comments

@ezsnackeur
Copy link
Contributor

Given how the training time works you can train a completely untrained astronaut faster, lets say for gemini, if he's training together with astronauts that already have the proficiency in mercury and this is intended.

Now the cheesy part: by starting a training with multiple trained astronauts and only 1 untrained one the time can be cut down considerably for the untrained one, after doing that the rest of the oroficient astronauts can be removed from training one by one without affecting the training time of the other ones.
Rinse and repeat and you can queue all untrained astronauts for a fast training, after which the already proficient astronaut can start a training on their own to get the maximum speed out of all the trainings.

@Clayell
Copy link
Contributor

Clayell commented Feb 6, 2025

Removing kerbalnauts from a training should probably recalculate the time of the training for all kerbals in that training
Hm, but it does. AddStudent and RemoveStudent both call RecalculateBP(), RecalculateBP calls _template.GetBaseTime, which should be calculating the time based off of the average training time of all of the kerbalnauts every time it is called through GetProficiencyTime.

@Clayell
Copy link
Contributor

Clayell commented Feb 6, 2025

Can you post some pictures or a video of this happening?

@ezsnackeur
Copy link
Contributor Author

5 nauts training all together
Image

proficient ones removed
Image

proficient ones starting a new training, only 10 days long
Image

@Clayell
Copy link
Contributor

Clayell commented Feb 6, 2025

Can you show a picture of what it is like if you just start to train the untrained astronauts?

@ezsnackeur
Copy link
Contributor Author

They take the full time with a small variance based on stupidity

@Clayell
Copy link
Contributor

Clayell commented Feb 6, 2025

Can you show this full time?

@ezsnackeur
Copy link
Contributor Author

training alone
Image

training with proficient nauts
Image

proficient nauts removed and starting their own 10d training, the time doesnt change for Selliah
Image

@Clayell
Copy link
Contributor

Clayell commented Feb 6, 2025

Thanks.

@Clayell
Copy link
Contributor

Clayell commented Feb 6, 2025

Hm, I'm lost. The only thing I can think of is that "Students.Remove(student);" does not work, but I do not think I can test that. All of the other pieces of code are exactly the same for adding a student as well, so if they were broken then the entire recalculation system would not work at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants