Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker swarm constructor has side-effects. #17

Open
molguin92 opened this issue Dec 24, 2021 · 0 comments
Open

Docker swarm constructor has side-effects. #17

molguin92 opened this issue Dec 24, 2021 · 0 comments
Assignees
Labels
bug Something isn't working CRITICAL

Comments

@molguin92
Copy link
Contributor

The Docker Swarm class constructor modifies the dictionaries passed as parameters. This should not happen as it introduces all sorts of hard-to-catch bugs.

Solution: The constructor should copy the dictionaries and operate on the copies.

@molguin92 molguin92 self-assigned this Dec 24, 2021
@molguin92 molguin92 added the bug Something isn't working label Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CRITICAL
Projects
None yet
Development

No branches or pull requests

1 participant