Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CoSim tasks #13021

Open
loumalouomega opened this issue Jan 20, 2025 · 3 comments
Open

New CoSim tasks #13021

loumalouomega opened this issue Jan 20, 2025 · 3 comments

Comments

@loumalouomega
Copy link
Member

Description

Proposed by @matekelemen:

  • Simplify inheritance structures
  • Make it clearer when and which InitializeSolutionStep and FinalizeSolutionStep is called
  • Extend support for other solvers
    • Star-CCM+
    • FLOWer (within WINSENTvalid project - probably restricted access)
    • OpenFOAM (give it more visibility and make sure it stays up to date with current Kratos versions)
@loumalouomega
Copy link
Member Author

OpenFOAM (give it more visibility and make sure it stays up to date with current Kratos versions)

We should deeply think about this , how to properly ensure that current implementations do not break. And of course we would need some kind of CI, but our resources are limited. Maybe we should define some kind of CI structure so at least these implementations are verified monthly.

@matekelemen
Copy link
Contributor

Maybe we should define some kind of CI structure so at least these implementations are verified monthly.

Yep, I think that's a good idea.

@philbucher
Copy link
Member

My vision for making sure this stuff doesnt always break was to make the examples-repo executable, at least then we would occasionally be able to check if things are still working
Ofc thats quite a bit or work...

Regarding flower, I wrote a dummy solver to make sure the coupling doesnt break. I doubt flower changes much, so thats probably not very critical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants