-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MissingAuthUrlException triggered when installing the app on a store with no theme #305
Comments
@Kyon147 can you please look into this issue ? |
@sunnyvaniya21 this is likely due to the theme level check that happens, it might need to be tweaked to now not expect being able to find the theme level. It's likely here or around here that needs debugging https://github.com/Kyon147/laravel-shopify/blob/master/src/Services/ThemeHelper.php#L109 |
The error come from the extractStoreMainTheme in the ThemeHelper. As a quick fix, you can add a try catch around the call of the Theme Support Level function in the InstallShop.php file in Actions. try{
$themeSupportLevel = call_user_func($this->verifyThemeSupport, $shop->getId());
$this->shopCommand->setThemeSupportLevel($shop->getId(), ThemeSupportLevel::fromNative($themeSupportLevel));
}catch(Exception $e){
$themeSupportLevel = null;
} |
#312 adds in your suggestion but have created a new enum for the value for null to keep things consistent |
…e null (#312) * Try and catch the theme support and any error we keep the theme null * linting * linting * linting
Expected Behavior
App should be installed normally with no error
Current Behavior
On installation on a new store with no theme, the MissingAuthUrlException is triggered
Failure Information
Steps to Reproduce
Please provide detailed steps for reproducing the issue.
Context
Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.
Failure Logs
[2024-04-30 07:30:51] local.ERROR: Missing auth url {"userId":1234,"exception":"[object] (Osiset\\ShopifyApp\\Exceptions\\MissingAuthUrlException(code: 0): Missing auth url at /my-app/vendor/kyon147/laravel-shopify/src/Traits/AuthController.php:55)
The text was updated successfully, but these errors were encountered: